Vulkan: Fix Out of Resources Crash #108416

Merged

Jeroen Bakker merged 1 commits from Jeroen-Bakker/blender:vulkan-crash-out-of-resources into main

2023-05-30 13:48:22 +02:00

Jeroen Bakker commented

2023-05-30 12:57:28 +02:00

Member

When a descriptor pool cannot allocate a descriptor set in stead
of resulting VK_ERROR_OUT_OF_POOL_MEMORY it is adviced that
drivers will return VK_ERROR_FRAGMENTED_POOL.

Before this PR the Vulkan Backend crashed as it only checked the
out of pool memory. According to the Vulkan specification it is
adviced to driver developers to report fragmented pool.

The crash happened as no new pool was allocated and no descriptor
set could be allocated anymore.

This change improved the reliability of the vulkan backend to be
able draw an animation in the 3d viewport for half an hour without
crashing. Before this change Blender would crash in a few seconds.

When a descriptor pool cannot allocate a descriptor set in stead of resulting `VK_ERROR_OUT_OF_POOL_MEMORY` it is adviced that drivers will return `VK_ERROR_FRAGMENTED_POOL`. Before this PR the Vulkan Backend crashed as it only checked the out of pool memory. According to the Vulkan specification it is adviced to driver developers to report fragmented pool. The crash happened as no new pool was allocated and no descriptor set could be allocated anymore. This change improved the reliability of the vulkan backend to be able draw an animation in the 3d viewport for half an hour without crashing. Before this change Blender would crash in a few seconds.

Jeroen Bakker added this to the 4.0 milestone 2023-05-30 12:57:28 +02:00

Jeroen Bakker added the

label 2023-05-30 12:57:28 +02:00

Jeroen Bakker self-assigned this 2023-05-30 12:57:28 +02:00

Jeroen Bakker added 1 commit 2023-05-30 12:57:35 +02:00

73ca4cd20e Vulkan: Fix Out of Resources Crash

When a descriptor pool cannot allocate a descriptor set in stead
of resulting `VK_ERROR_OUT_OF_POOL_MEMORY` it is adviced that
drivers will return `VK_ERROR_FRAGMENTED_POOL`.

Before this PR the Vulkan Backend crashed as it only checked the
out of pool memory. According to the Vulkan specification it is
adviced to driver developers to report fragmented pool.

The crash happened as no new pool was allocated and no descriptor
set could be allocated anymore.

This change improved the reliability of the vulkan backend to be
able draw an animation in the 3d viewport for half an hour without
crashing. Before this change Blender would crash in a few seconds.

Jeroen Bakker added this to the EEVEE & Viewport project 2023-05-30 12:57:47 +02:00

Jeroen Bakker merged commit 2cc0f94d68 into main

2023-05-30 13:48:22 +02:00

Jeroen Bakker referenced this issue from a commit

2023-05-30 13:48:23 +02:00

Vulkan: Fix Out of Resources Crash

Jeroen Bakker deleted branch vulkan-crash-out-of-resources

2023-05-30 13:48:23 +02:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108416

No description provided.