Fix #102737: Keyframe jump operator includes hidden curves in Graph Editor #108549
The graph editor has the function to hide the display of FCurves and to only draw keyframes on selected curves.
Both options were not respected when executing the frame jump operator, meaning it would jump to potentially hidden keyframes.
This patch adds a new operator that is specific to the Graph Editor and that respects those features.
The only possible issue that could arise from this is a slight confusion for the user why they behave differently between editors. Especially with only the Graph Editor and the 3D view open. In general I think it's an improvement and follows the "you can only modify what you see" mantra in blender
I had a look at changing the existing operator, but the keylist generation has no notion of where it is being called from, and IMO it shouldn't need to. So the logical conclusion was a more specific modifier in the GE.
LGTM! Just a small request, can be done before landing.
The new graph.keyframe_jump is working incorrectly in NLA tweak strips actions mode with pinned on and the strip has frame start offset or time scale.
The operator jumps to the keyframes of the source action instead of the pinned time remapped keyframes.
screen.keyframe_jump works as expected, but not this new graph.keyframe_jump
Steps to reproduce
- Open the attached "graph.keyframe_jump_NLA-test.blend"
- With the "Cube" object selected and the NLA strip "CubeAction" selected in the NLA editor, press 'Tab' to enter tweak strip actions mode
- With the mouse over Graph Editor, press the default 'up' or 'down' arrow keys to jump to next or previous keyframes.
@Tajino thanks for letting us know. In the future please make a new bug report, this makes it easier for us to track
I made on now #110789: Keyframe jump operator in the Graph Editor does not respect NLA offset
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?