UI: move 'Face Nearest' snap option to another section #108555

Merged
Germano Cavalcante merged 1 commits from mano-wii/blender:transform_nearest_ui into main 2023-06-06 19:36:02 +02:00

The snap mode called "Face Nearest" (and the "Increment" but that's for
another time) doesn't behave like the other snap modes.

Unlike the other snap modes, "Face Nearest" does not act on a Snap
Base (or Snap Source).

It always acts on the origin of individually transformed elements, (such
as each vertex individually).

It works just like the "Project Individual Elements" option.

So this commit makes the following changes:

  • Snap With was moved to the beginning of the popover
  • Align Rotation to Target and Backface Culling have been moved closer to the snap targets
  • Snap With, Target Selection and Align Rotation to Target are no longer hidden by varying the mode and options
  • Project Individual Elements has been replaced with the Face Project option
  • Face Nearest has been moved to stick together with the Face Project option

GIF.gif

The snap mode called "Face Nearest" (and the "Increment" but that's for another time) doesn't behave like the other snap modes. Unlike the other snap modes, "Face Nearest" does not act on a Snap Base (or Snap Source). It always acts on the origin of individually transformed elements, (such as each vertex individually). It works just like the "Project Individual Elements" option. So this commit makes the following changes: - `Snap With` was moved to the beginning of the popover - `Align Rotation to Target` and `Backface Culling` have been moved closer to the snap targets - `Snap With`, `Target Selection` and `Align Rotation to Target` are no longer hidden by varying the mode and options - `Project Individual Elements` has been replaced with the `Face Project` option - `Face Nearest` has been moved to stick together with the `Face Project` option ___ ![GIF.gif](attachments/62863973-1bb3-4545-8641-89a2ce0f3721)
Germano Cavalcante changed title from UI: move 'Face Nearest' snap option to another session to WIP: UI: move 'Face Nearest' snap option to another session 2023-06-02 18:02:52 +02:00
Germano Cavalcante requested review from Campbell Barton 2023-06-02 18:02:53 +02:00
Germano Cavalcante added the
Interest
User Interface
label 2023-06-02 18:03:06 +02:00
Germano Cavalcante force-pushed transform_nearest_ui from ef658a9dbc to 12ec9f5d89 2023-06-03 14:45:48 +02:00 Compare
Germano Cavalcante requested review from jon denning 2023-06-03 14:47:59 +02:00
Germano Cavalcante reopened this pull request 2023-06-03 15:16:30 +02:00
Member

my initial thoughts: these changes are not ideal for retopo work.

  • it eliminates the ability to use face project and/or face nearest only without having at least one of the other options selected (increment, vertex, ...) which is highly problematic.
  • the target selection filtering has been removed

I agree that the mixed behavior in these options is confusing. there is no way to understand what each option does without reading the documentation. this confusion is especially true when several options are selected.

your changes are related to what I proposed in Add Retopology Mode as Snapping Option (D15406), where the different behaving snapping options would be "hidden" in its own context and not clutter the 95%* use case of snapping. can we try revisiting that as an option to declutter the snap panel?

*stat pulled out of thin air, but it's probably not too far off.

my initial thoughts: these changes are not ideal for retopo work. - it eliminates the ability to use face project and/or face nearest only without having at least one of the other options selected (increment, vertex, ...) which is highly problematic. - the target selection filtering has been removed I agree that the mixed behavior in these options is confusing. there is no way to understand what each option does without reading the documentation. this confusion is especially true when several options are selected. your changes are related to what I proposed in [Add Retopology Mode as Snapping Option (D15406)](https://archive.blender.org/developer/D15406), where the different behaving snapping options would be "hidden" in its own context and not clutter the 95%* use case of snapping. can we try revisiting that as an option to declutter the snap panel? *stat pulled out of thin air, but it's probably not too far off.
Germano Cavalcante force-pushed transform_nearest_ui from 12ec9f5d89 to 3eb523e1af 2023-06-03 17:49:39 +02:00 Compare
Author
Member
  • it eliminates the ability to use face project and/or face nearest only without having at least one of the other options selected (increment, vertex, ...) which is highly problematic.

I decided to solve this by making the two types of snaps and place then in different lists. When selecting an element from a list, all elements from the other list are deselected.

  • the target selection filtering has been removed

It was not intentional.

(I'm also not a big fan of hiding options depending on the other option. We can create "Format Presets" for cases where specific settings are more desirable)

> - it eliminates the ability to use face project and/or face nearest only without having at least one of the other options selected (increment, vertex, ...) which is highly problematic. I decided to solve this by making the two types of snaps and place then in different lists. When selecting an element from a list, all elements from the other list are deselected. > - the target selection filtering has been removed It was not intentional. (I'm also not a big fan of hiding options depending on the other option. We can create "Format Presets" for cases where specific settings are more desirable)
Germano Cavalcante changed title from WIP: UI: move 'Face Nearest' snap option to another session to UI: move 'Face Nearest' snap option to another session 2023-06-03 18:10:20 +02:00
Member

i agree with you that hiding options makes for poor UX (the options are just missing, but artist has no feedback as to why).

i've haven't pulled your changes and tested locally, but i think visually these changes are much clearer!

maybe change "Project Individual Elements" to "Snap Individual Elements"?

does everything still work as expected in edit mode?

it is a little odd that selecting face project or face nearest causes the dropdown to say "Mix", even if only one method is chosen.

i agree with you that hiding options makes for poor UX (the options are just missing, but artist has no feedback as to why). i've haven't pulled your changes and tested locally, but i think visually these changes are much clearer! maybe change "Project Individual Elements" to "Snap Individual Elements"? does everything still work as expected in edit mode? it is a little odd that selecting face project or face nearest causes the dropdown to say "Mix", even if only one method is chosen.
Germano Cavalcante force-pushed transform_nearest_ui from 3eb523e1af to 50a3f60488 2023-06-05 17:33:21 +02:00 Compare
Author
Member

Update

Changes:

  • Renamed "Project Individual Elements" to "Snap Individual Elements To"
  • Renamed "Snap With" to "Snap Source"
  • Renamed "Snap To" to "Snap Source To"
  • Fixed "Mix" name

Other name suggestions: "Snap Target", "Snap Individual Elements Target"

Update Changes: - Renamed "Project Individual Elements" to "Snap Individual Elements To" - Renamed "Snap With" to "Snap Source" - Renamed "Snap To" to "Snap Source To" - Fixed "Mix" name Other name suggestions: "Snap Target", "Snap Individual Elements Target"
Campbell Barton changed title from UI: move 'Face Nearest' snap option to another session to UI: move 'Face Nearest' snap option to another section 2023-06-06 02:55:45 +02:00
Campbell Barton approved these changes 2023-06-06 07:53:48 +02:00
Germano Cavalcante force-pushed transform_nearest_ui from 50a3f60488 to 6113be9538 2023-06-06 15:13:38 +02:00 Compare
Author
Member

Update.

Changes:

  • Reverted "Snap With" and "Snap To" name changes (fewer changes)
  • Fixed Mixed Individual Snap
Update. Changes: - Reverted "Snap With" and "Snap To" name changes (fewer changes) - Fixed Mixed Individual Snap
Germano Cavalcante force-pushed transform_nearest_ui from 6113be9538 to 798d515ec5 2023-06-06 19:34:05 +02:00 Compare
Germano Cavalcante merged commit 8e059b569b into main 2023-06-06 19:36:02 +02:00
Germano Cavalcante deleted branch transform_nearest_ui 2023-06-06 19:36:03 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108555
No description provided.