Fix #108778: Crash when rendering multiple view layers #108816

Merged

Sergey Sharybin merged 1 commits from Sergey/blender:fix_108778 into main

2023-06-09 18:42:08 +02:00

Sergey Sharybin commented

2023-06-09 18:09:15 +02:00

Owner

The rendering pipeline will re-use dependency graph and request
for re-building its relations for every new view layer, and try
to re-use as much evaluation as possible.

This could potentially run into situation when a content of
collection is changed: due to the difference in the per-view
layer visibility. If the evaluated collection has an object cache
this will make the cache to get out-of-sync with the actual
content. The cache on the evaluated collection might be created
when instancing system iterates over the collection.

This change makes it so the cache is freed when the dependency
graph relations are updated. This might be a bit too intrusive.
There might be ways to somehow ensure the content of the collection
is still the same as it was before the relations update, but this
is much more complicated task. Perhaps the performance is already
good enough.

This is a collaboration with Jacques Lucke, who was looking into
the same report, bouncing some ideas back and forth, and helped
testing the patch.

The rendering pipeline will re-use dependency graph and request for re-building its relations for every new view layer, and try to re-use as much evaluation as possible. This could potentially run into situation when a content of collection is changed: due to the difference in the per-view layer visibility. If the evaluated collection has an object cache this will make the cache to get out-of-sync with the actual content. The cache on the evaluated collection might be created when instancing system iterates over the collection. This change makes it so the cache is freed when the dependency graph relations are updated. This might be a bit too intrusive. There might be ways to somehow ensure the content of the collection is still the same as it was before the relations update, but this is much more complicated task. Perhaps the performance is already good enough. This is a collaboration with Jacques Lucke, who was looking into the same report, bouncing some ideas back and forth, and helped testing the patch.

Sergey Sharybin added the

Dependency Graph

labels 2023-06-09 18:09:16 +02:00

Sergey Sharybin added 1 commit 2023-06-09 18:09:26 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

1081fa77de Fix 108778: Crash when rendering multiple view layers

The rendering pipeline will re-use dependency graph and request
for re-building its relations for every new view layer, and try
to re-use as much evaluation as possible.

This could potentially run into situation when a content of
collection is changed: due to the difference in the per-view
layer visibility. If the evaluated collection has an object cache
this will make the cache to get out-of-sync with the actual
content. The cache on the evaluated collection might be created
when instancing system iterates over the collection.

This change makes it so the cache is freed when the dependency
graph relations are updated. This might be a bit too intrusive.
There might be ways to somehow ensure the content of the collection
is still the same as it was before the relations update, but this
is much more complicated task. Perhaps the performance is already
good enough.

This is a collaboration with Jacques Lucke, who was looking into
the same report, bouncing some ideas back and forth, and helped
testing the patch.

Sergey Sharybin commented

2023-06-09 18:09:34 +02:00

Author

Owner

@blender-bot build

@blender-bot build

Sergey Sharybin requested review from Jacques Lucke 2023-06-09 18:09:43 +02:00

Sergey Sharybin changed title from ~~Fix 108778: Crash when rendering multiple view layers~~ to Fix #108778: Crash when rendering multiple view layers

2023-06-09 18:10:06 +02:00

Jacques Lucke approved these changes 2023-06-09 18:11:36 +02:00

Sergey Sharybin merged commit 823514fd6f into main

2023-06-09 18:42:08 +02:00

Sergey Sharybin deleted branch fix_108778

2023-06-09 18:42:09 +02:00

Sergey Sharybin referenced this issue from a commit

2023-06-09 18:42:12 +02:00

Fix #108778: Crash when rendering multiple view layers

Jacques Lucke referenced this issue from a commit

2023-06-20 11:43:01 +02:00

Fix #108778: Crash when rendering multiple view layers

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108816

No description provided.