macOS: upgrade to Xcode 15 #110243

Brecht Van Lommel · 2023-07-18T17:22:55+02:00

Brecht Van Lommel commented

2023-07-18 17:22:55 +02:00

For official 4.0 builds, older Xcode versions keep working.

The new linker in Xcode 15 gives many warnings due to duplicated
libraries, generated by CMake to resolve circular dependencies. For now
use the old linker to silence these warnings.

Remove legacy flags for libc++, this is the default for a long time and
generates warnings with the new linker.

Reason for upgrade is to take advantage of MetalRT curve support.

For official 4.0 builds, older Xcode versions keep working. The new linker in Xcode 15 gives many warnings due to duplicated libraries, generated by CMake to resolve circular dependencies. For now use the old linker to silence these warnings. Remove legacy flags for libc++, this is the default for a long time and generates warnings with the new linker. Reason for upgrade is to take advantage of MetalRT curve support.

Brecht Van Lommel added 1 commit 2023-07-18 17:23:04 +02:00

macOS: test Xcode 15

buildbot/vexp-code-patch-coordinator Build done.

Details

61d6b3fe68

Brecht Van Lommel referenced this pull request from infrastructure/blender-projects-platform

2023-07-18 17:32:49 +02:00

Upgrade macOS buildbots to have 13.3 SDK #62

Brecht Van Lommel commented

2023-07-18 17:38:46 +02:00

This shows many linker warnings, presumably due to the new linker included in Xcode 15.
https://builder-uatest.blender.org/admin/#/builders/170/builds/77

This shows many linker warnings, presumably due to the new linker included in Xcode 15. https://builder-uatest.blender.org/admin/#/builders/170/builds/77

Brecht Van Lommel commented

2023-07-18 19:18:43 +02:00

@blender-bot build macos

Brecht Van Lommel added 1 commit 2023-07-20 15:14:04 +02:00

Test older linker

buildbot/vexp-code-patch-coordinator Build done.

Details

eb038e7375

Brecht Van Lommel commented

2023-07-20 15:14:37 +02:00

@blender-bot build macos

Brecht Van Lommel added 1 commit 2023-07-21 13:34:02 +02:00

Remove unnecessary flags that give linker warnings fe5988ad16

Embree is now dynamic, libc++ is the default and only choice.

Brecht Van Lommel commented

2023-07-21 14:51:14 +02:00

So this warning was fixed:

ld: warning: ignoring duplicate library '-lc++'

The next one comes from the homebrew environment setting LIBRARY_PATH=/usr/local/lib. Not quite sure what the best way of dealing with that is. Maybe it needs to be solved in homebrew, to avoid setting this when the directory does not exist.

ld: warning: search path '/usr/local/lib' not found

The next types of warnings actually happen with both the old and new linker, and are due to circular dependencies, which causes CMake to generate the libs twice. Realistically we can not solve the circular dependencies any time soon.

Maybe there will be a change in CMake to not generate duplicate static libraries for Xcode 15+, since I guess those linkers do not need it. I did not see any CMake feature that could disable this.

Or the macOS linker could get a flag to silence these warnings.

ld: warning: ignoring duplicate static library 'lib/libbf_intern_guardedalloc.a'
ld: warning: ignoring duplicate static library '/Users/blender/git/blender-vexp/lib/darwin_arm64/openimagedenoise/lib/libOpenImageDenoise.a'
ld: warning: ignoring duplicate static library '/Users/blender/git/blender-vexp/lib/darwin_arm64/openimagedenoise/lib/libcommon.a'
ld: warning: ignoring duplicate static library '/Users/blender/git/blender-vexp/lib/darwin_arm64/gmp/lib/libgmpxx.a'
ld: warning: ignoring duplicate static library '/Users/blender/git/blender-vexp/lib/darwin_arm64/gmp/lib/libgmp.a'
ld: warning: ignoring duplicate library '-force_load'

For these I have no idea what is going on. Maybe they will disappear with an upgrade to OIDN 2 since these files no longer exist. And additionally we'll switch to dynamic instead of static libraries.

ld: warning: no platform load command found in '/Users/blender/git/blender-vexp/lib/darwin_arm64/openimagedenoise/lib/libOpenImageDenoise.a[25](input_reorder.dev.o)', assuming: macOS
ld: warning: no platform load command found in '/Users/blender/git/blender-vexp/lib/darwin_arm64/openimagedenoise/lib/libOpenImageDenoise.a[26](color.dev.o)', assuming: macOS
ld: warning: no platform load command found in '/Users/blender/git/blender-vexp/lib/darwin_arm64/openimagedenoise/lib/libOpenImageDenoise.a[28](output_copy.dev.o)', assuming: macOS
ld: warning: no platform load command found in '/Users/blender/git/blender-vexp/lib/darwin_arm64/openimagedenoise/lib/libOpenImageDenoise.a[29](output_reorder.dev.o)', assuming: macOS

So this warning was fixed: ``` ld: warning: ignoring duplicate library '-lc++' ``` The next one comes from the homebrew environment setting `LIBRARY_PATH=/usr/local/lib`. Not quite sure what the best way of dealing with that is. Maybe it needs to be solved in homebrew, to avoid setting this when the directory does not exist. ``` ld: warning: search path '/usr/local/lib' not found ``` The next types of warnings actually happen with both the old and new linker, and are due to circular dependencies, which causes CMake to generate the libs twice. Realistically we can not solve the circular dependencies any time soon. Maybe there will be a change in CMake to not generate duplicate static libraries for Xcode 15+, since I guess those linkers do not need it. I did not see any CMake feature that could disable this. Or the macOS linker could get a flag to silence these warnings. ``` ld: warning: ignoring duplicate static library 'lib/libbf_intern_guardedalloc.a' ld: warning: ignoring duplicate static library '/Users/blender/git/blender-vexp/lib/darwin_arm64/openimagedenoise/lib/libOpenImageDenoise.a' ld: warning: ignoring duplicate static library '/Users/blender/git/blender-vexp/lib/darwin_arm64/openimagedenoise/lib/libcommon.a' ld: warning: ignoring duplicate static library '/Users/blender/git/blender-vexp/lib/darwin_arm64/gmp/lib/libgmpxx.a' ld: warning: ignoring duplicate static library '/Users/blender/git/blender-vexp/lib/darwin_arm64/gmp/lib/libgmp.a' ld: warning: ignoring duplicate library '-force_load' ``` For these I have no idea what is going on. Maybe they will disappear with an upgrade to OIDN 2 since these files no longer exist. And additionally we'll switch to dynamic instead of static libraries. ``` ld: warning: no platform load command found in '/Users/blender/git/blender-vexp/lib/darwin_arm64/openimagedenoise/lib/libOpenImageDenoise.a[25](input_reorder.dev.o)', assuming: macOS ld: warning: no platform load command found in '/Users/blender/git/blender-vexp/lib/darwin_arm64/openimagedenoise/lib/libOpenImageDenoise.a[26](color.dev.o)', assuming: macOS ld: warning: no platform load command found in '/Users/blender/git/blender-vexp/lib/darwin_arm64/openimagedenoise/lib/libOpenImageDenoise.a[28](output_copy.dev.o)', assuming: macOS ld: warning: no platform load command found in '/Users/blender/git/blender-vexp/lib/darwin_arm64/openimagedenoise/lib/libOpenImageDenoise.a[29](output_reorder.dev.o)', assuming: macOS ```

Brecht Van Lommel added 1 commit 2023-09-07 19:04:23 +02:00

Merge remote-tracking branch 'origin/main' into HEAD 0ab777c02a

Brecht Van Lommel added 1 commit 2023-09-07 19:30:49 +02:00

Try new linker again f24508004b

Brecht Van Lommel added 1 commit 2023-09-07 19:45:08 +02:00

Try older linker again 3acc177c28

Brecht Van Lommel added 1 commit 2023-09-07 19:59:36 +02:00

Only use old linker flags for Xcode15+

buildbot/vexp-code-patch-coordinator Build done.

Details

8c01f05bf0

Brecht Van Lommel changed title from ~~WIP: macOS: test Xcode 15~~ to macOS: upgrade to Xcode 15

2023-09-07 20:03:35 +02:00

Brecht Van Lommel changed title from ~~macOS: upgrade to Xcode 15~~ to macOS: upgrade buildbot to Xcode 15

2023-09-07 20:04:07 +02:00

Brecht Van Lommel changed title from ~~macOS: upgrade buildbot to Xcode 15~~ to macOS: upgrade to Xcode 15

2023-09-07 20:04:17 +02:00

Brecht Van Lommel commented

2023-09-07 20:05:01 +02:00

@blender-bot package macos

Blender Bot commented

2023-09-07 20:05:04 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR110243) when ready.

Brecht Van Lommel commented

2023-09-07 20:05:59 +02:00

It appears that the warnings no longer exist for the old linker, but are still there for the new linker. So use the old linker for now.

An example of the warnings with the new linker:
https://builder-uatest.blender.org/admin/#/builders/24/builds/10/steps/3/logs/stdio

It appears that the warnings no longer exist for the old linker, but are still there for the new linker. So use the old linker for now. An example of the warnings with the new linker: https://builder-uatest.blender.org/admin/#/builders/24/builds/10/steps/3/logs/stdio

Brecht Van Lommel added 1 commit 2023-09-08 15:56:57 +02:00

Fix Xcode version check only working with Xcode generator

buildbot/vexp-code-patch-coordinator Build done.

Details

c6f8eaeb82

Brecht Van Lommel commented

2023-09-08 15:57:07 +02:00

@blender-bot package macos