Animation: Match Slope slider #110567
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#110567
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "ChrisLend/blender:blend_to_infinity_slider"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This patch has been authored by Ares Deveaux (#106517: Animation: blend to infinity slider)
I am just finishing it up.
It blends selected keys to the slant of neighboring ones.
It is used to push the segment closer to the values of the next or previous pose.
@ -682,0 +683,4 @@
{
const BezTriple *left_key = fcurve_segment_start_get(fcu, segment->start_index);
const BezTriple *right_key = fcurve_segment_end_get(fcu, segment->start_index + segment->length);
Nothing to do with this PR, but just a side-note that these
fcurve_segment_*_get()
functions are (IMO) poorly named. I would expect them to get the first and last keys within the selected segment, but in fact they attempt to get the keys before and after the segment, which are not themselves part of the segment (falling back to the actual start and end key of the segment only if the before/after don't exist).Further,
fcurve_segment_start_get()
takes an inclusive start index whereasfcurve_segment_end_get()
takes an exclusive end index. That makes sense from the standpoint of easily computing the index to pass from the segment data, but these clearly aren't actually specific to segments since you can pass any indices you want.And that brings me to it being weird that
segment
is even part of their name, since they don't take segments, they directly take indices.All in all, it took me way more time than it should have to figure out what was going on here, and at first I thought we had off-by-one indexing errors (which isn't the case) because of how confusing this was.
imo, In the context of getting
*left_key
and*right_key
i thinkfcurve_segment_*_get()
is understandable. I do think there needs to be some comments around inclusivity.Ah, interesting. I interpreted it to mean "left/right-most key of the segment". Although that's probably because of the
fcurve_segment_*_get
names, in my case.In any case, I think the
fcurve_segment_*_get()
names are confusing, at least on their own. But that's definitely not for this PR (and also not @ChrisLend's code, ha ha).The code looks good to me. But I have a couple of thoughts:
lgtm.
I think we should bring up the name in the next Animation module meeting. I think an argument could be made either way, but would be good to get others feedback.
Good call. Added to the agenda.
The consensus in the module meeting was to rename this to "Match Slope". Other than that, this looks ready to land to me.
@ -1077,0 +1129,4 @@
WM_event_add_notifier(C, NC_ANIMATION | ND_KEYFRAME | NA_EDITED, NULL);
}
static int blend_to_infinity_invoke(bContext *C, wmOperator *op, const wmEvent *event)
Missed an infinity.
thanks, must be going blind
Animation: Blend to Infinity sliderto Animation: Match Slope sliderLooks good to me!