blender/blender
168
526
Fork 800
Code Issues 6.6k Pull Requests 954 Projects 21 Wiki Activity

Color management: Validate Look on View Transform changes #111185

Merged
Sergey Sharybin merged 2 commits from Sergey/blender:cm_look_on_view_change into main 2023-08-17 14:38:15 +02:00
Conversation 0 Commits 2 Files Changed 3 +41 -7
Sergey Sharybin commented 2023-08-16 16:34:37 +02:00
Owner
Copy Link

If the new view transform does not support the currently configured
look reset look to the default None, similar to the color management
verification on .blend file open.

Currently it is not a problem as all views support the same set of
looks. But with an upcoming addition of AgX it will no longer be
true.

Ref #110685

If the new view transform does not support the currently configured look reset look to the default None, similar to the color management verification on .blend file open. Currently it is not a problem as all views support the same set of looks. But with an upcoming addition of AgX it will no longer be true. Ref #110685
Sergey Sharybin added the
Module
Render & Cycles
 label 2023-08-16 16:34:37 +02:00
Sergey Sharybin added 1 commit 2023-08-16 16:34:52 +02:00 
If the new view transform does not support the currently configured
look reset look to the default: the first look defined for the view.

Currently it is not a problem as all views support the same set of
looks. But with an upcoming addition of AgX it will no longer be
true.

Ref #110685
Sergey Sharybin requested review from Brecht Van Lommel 2023-08-16 16:34:56 +02:00
Brecht Van Lommel requested changes 2023-08-16 19:21:27 +02:00
source/blender/imbuf/intern/colormanagement.cc Outdated
@ -3314,6 +3314,39 @@ const char *IMB_colormanagement_look_get_indexed_name(int index)
return nullptr;
}
const char *IMB_colormanagement_look_get_default_name_for_view(const char *view_name)
Brecht Van Lommel commented 2023-08-16 19:20:29 +02:00
Owner
Copy Link

Shouldn't the default look be None, so not a look but just ""?

Shouldn't the default look be None, so not a look but just `""`?
Sergey Sharybin commented 2023-08-17 10:16:32 +02:00
Author
Owner
Copy Link

Looks are identified by name, and "" is not a valid name, it needs to be "None".

But this comment made me to go check on how the color management settings are validated on .blend file open. There the first look from the global list is used, and it is colormanage_look_add("None", "", true);.

So, I've made that piece of code more re-usable and aligned the behavior of the runtime check to the validation on file-open. So now with this patch the run-time validation result is the same as if you save-reload before this change. At least so it is expected :)

Looks are identified by name, and `""` is not a valid name, it needs to be `"None"`. But this comment made me to go check on how the color management settings are validated on .blend file open. There the first look from the global list is used, and it is `colormanage_look_add("None", "", true);`. So, I've made that piece of code more re-usable and aligned the behavior of the runtime check to the validation on file-open. So now with this patch the run-time validation result is the same as if you save-reload before this change. At least so it is expected :)
Sergey Sharybin commented 2023-08-17 10:25:48 +02:00
Author
Owner
Copy Link

Actually, the versioning code does not check the look is compatible with the view.
Well, that'd need to be addressed, but as separate PR! :)

Actually, the versioning code does not check the look is compatible with the view. Well, that'd need to be addressed, but as separate PR! :)
Sergey Sharybin added 1 commit 2023-08-17 10:12:02 +02:00 
In practice this means that if the new View does not support old
Look, a None look is used.
Brecht Van Lommel approved these changes 2023-08-17 13:49:28 +02:00
Sergey Sharybin merged commit 241fac09dd into main 2023-08-17 14:38:15 +02:00
Sergey Sharybin deleted branch cm_look_on_view_change 2023-08-17 14:38:17 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brecht Van Lommel
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Code Documentation
Code comments, Python/RNA API descriptions

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
FBX
FBX I/O related topics

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
glTF
glTF format I/O topics

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/

  
Module
Animation & Rigging

  
Module
Asset System

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
glTF
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111185
No description provided.
Delete Branch "Sergey/blender:cm_look_on_view_change"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?