Anim: Insert keyframes without keying sets #113504

Merged
Christoph Lendenfeld merged 59 commits from ChrisLend/blender:keying_sets_rework into main 2023-11-21 15:38:09 +01:00
2 changed files with 3 additions and 1 deletions
Showing only changes of commit c79a3423a2 - Show all commits

View File

@ -169,7 +169,8 @@ bool autokeyframe_property(bContext *C,
/** \} */
/**
* Insert a key in the given action.
* Insert keys for the given rna_path in the given action. The length of the values Span is
* expected to be the size of the property array.
* \param frame is expected to be in NLA space.
nathanvegdahl marked this conversation as resolved Outdated

Really glad this note on frame parameters is here. However, what does NLA space mean in this case? Local time of the action? Time on the NLA track? I think this could be rephrased or expanded on to be clearer.

Really glad this note on frame parameters is here. However, what does NLA space mean in this case? Local time of the action? Time on the NLA track? I think this could be rephrased or expanded on to be clearer.
*/
int insert_key_action(Main *bmain,
nathanvegdahl marked this conversation as resolved Outdated

What is the integer return value? Let's document that too, because at least to me (having not seen the function body yet as I work my way through the PR) it's not at all obvious.

What is the integer return value? Let's document that too, because at least to me (having not seen the function body yet as I work my way through the PR) it's not at all obvious.

View File

@ -967,6 +967,7 @@ int insert_key_action(Main *bmain,
const float frame,
const Span<float> values)
{
BLI_assert(bmain != nullptr);
BLI_assert(action != nullptr);
std::string group;