Fix #116317: Ensure that USD materials reside in a Prim Scope #116460

Merged
Jesse Yurkovich merged 1 commits from deadpin/blender:fix116317-materialscope into main 2024-01-12 20:31:51 +01:00

There's been feedback that placing them inside a Scope better aligns
with other DCCs and makes some aspects of tooling more consistent in the
ecosystem.

Note: it was not a spec violation to have the typeless def that we used
before.

There's been feedback that placing them inside a Scope better aligns with other DCCs and makes some aspects of tooling more consistent in the ecosystem. Note: it was not a spec violation to have the typeless def that we used before.
Jesse Yurkovich added 1 commit 2023-12-22 06:39:42 +01:00
Jesse Yurkovich requested review from Michael Kowalski 2023-12-22 06:39:56 +01:00
Jesse Yurkovich requested review from Michael B Johnson 2023-12-22 06:39:57 +01:00
Michael Kowalski approved these changes 2023-12-22 14:39:15 +01:00
Michael Kowalski left a comment
Member

The change looks good. Thanks for this fix!

The change looks good. Thanks for this fix!
Member

Thanks, Jesse, looks good to me!

Thanks, Jesse, looks good to me!
Author
Member

@Matt-McLin Thanks! Would you be able to help describe the scenario that isn't working currently so I can put that in the PR description? I tried a couple simple SdfCopySpec calls that seemed to do what I wanted but I'm guessing there's some nuance here that I missed.

@Matt-McLin Thanks! Would you be able to help describe the scenario that isn't working currently so I can put that in the PR description? I tried a couple simple SdfCopySpec calls that seemed to do what I wanted but I'm guessing there's some nuance here that I missed.

Friendly ping about this.

I think it would be fine to see this merged saying it aligns with other DCCs though, which is a good way to avoid problems regardless.

Friendly ping about this. I think it would be fine to see this merged saying it aligns with other DCCs though, which is a good way to avoid problems regardless.
Jesse Yurkovich merged commit 24964575e7 into main 2024-01-12 20:31:51 +01:00
Jesse Yurkovich deleted branch fix116317-materialscope 2024-01-12 20:31:54 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116460
No description provided.