Anim: Change tooltip for Insert Needed and Insert Available #117270

Merged
Christoph Lendenfeld merged 5 commits from ChrisLend/blender:user_pref_keying_tooltips into main 2024-02-01 10:52:58 +01:00

This changes the tooltip for the user preference settings
Only Insert Needed and Only Insert Available
to better explain what these features are for.

- Before After
Only Insert Available Automatic keyframe insertion in available F-Curves Insert Keyframes only for properties that are already animated
Auto-Key Needed Auto-Keyframe insertion only when keyframe needed Auto-Keying will skip inserting keys that don't affect the animation
Manual Key Needed Keyframe insertion only when keyframe needed When keying manually, skip inserting keys that don't affect the animation

This was discussed in the A&R module meeting. As a result the description for insert needed has been changed.

This changes the tooltip for the user preference settings `Only Insert Needed` and `Only Insert Available` to better explain what these features are for. | - | Before | After | | - | - | - | | Only Insert Available | Automatic keyframe insertion in available F-Curves | Insert Keyframes only for properties that are already animated | | Auto-Key Needed | Auto-Keyframe insertion only when keyframe needed | Auto-Keying will skip inserting keys that don't affect the animation | | Manual Key Needed | Keyframe insertion only when keyframe needed | When keying manually, skip inserting keys that don't affect the animation | ------ This was discussed in the [A&R module meeting](https://devtalk.blender.org/t/2024-01-26-animation-rigging-module-meeting/33081#patch-review-decision-time-5). As a result the description for insert needed has been changed.
Christoph Lendenfeld added the
Module
Animation & Rigging
label 2024-01-18 11:10:40 +01:00
Christoph Lendenfeld added 1 commit 2024-01-18 11:10:53 +01:00
Christoph Lendenfeld added 2 commits 2024-01-19 17:33:16 +01:00
Christoph Lendenfeld changed title from WIP: Anim: Change tooltip for Insert Needed and Insert Available to Anim: Change tooltip for Insert Needed and Insert Available 2024-01-19 17:33:49 +01:00

Auto-Key Needed : Auto-Keying will only insert keyframes for properties that have been modified

I think "inserting keyframes for properties that have been modified" reads pretty much as a description of autokeying in general. How about something like this? I think the wording could be improved; I think mostly that describing when auto-keying does not create a key might help to clarify.

"Skip auto-keying when the key would be placed exactly on its existing F-Curve. For this, it doesn't matter whether there is a key on this frame or not; the property is also skipped when it matches its current interpolation."

And of course the change should be applied to the 'manual' case too.

> Auto-Key Needed : Auto-Keying will only insert keyframes for properties that have been modified I think "inserting keyframes for properties that have been modified" reads pretty much as a description of autokeying in general. How about something like this? I think the wording could be improved; I think mostly that describing when auto-keying does **not** create a key might help to clarify. "Skip auto-keying when the key would be placed exactly on its existing F-Curve. For this, it doesn't matter whether there is a key on this frame or not; the property is also skipped when it matches its current interpolation." And of course the change should be applied to the 'manual' case too.
Member

This is way clearer! Love it.

Just a minor nit: it might flow better if the Auto-Key Manual and Auto-Key Needed tooltips use wording that mirrors each other. Then again, maybe that's just because I'm seeing them right next to each other.

(Also, in the PR description, I think "Auto-Key Manual" is the wrong name? Wouldn't it be "Manual Key Needed", or something like that? No biggie.)

This is *way* clearer! Love it. Just a minor nit: it might flow better if the Auto-Key Manual and Auto-Key Needed tooltips use wording that mirrors each other. Then again, maybe that's just because I'm seeing them right next to each other. (Also, in the PR description, I think "Auto-Key Manual" is the wrong name? Wouldn't it be "Manual Key Needed", or something like that? No biggie.)
Christoph Lendenfeld added 2 commits 2024-01-26 14:33:37 +01:00
Author
Member

I've implemented the changes as discussed in the A&R module meeting

I've implemented the changes as discussed in the [A&R module meeting](https://devtalk.blender.org/t/2024-01-26-animation-rigging-module-meeting/33081#patch-review-decision-time-5)
Nathan Vegdahl approved these changes 2024-02-01 10:21:13 +01:00
Nathan Vegdahl left a comment
Member

Looks good to me!

Looks good to me!
Christoph Lendenfeld merged commit 8771e0c4ce into main 2024-02-01 10:52:58 +01:00
Christoph Lendenfeld deleted branch user_pref_keying_tooltips 2024-02-01 10:53:01 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117270
No description provided.