From c267639be274d0586bbf7d64969208ad6b28552d Mon Sep 17 00:00:00 2001 From: Amine Bensalem Date: Tue, 20 Feb 2024 14:21:22 +0100 Subject: [PATCH 1/3] Fix #118137: Toolbar symmetry buttons not updated on click. Axis symmetry buttons on the toolbar didn't update their state when their equivalent buttons on other areas were clicked. --- source/blender/editors/space_buttons/space_buttons.cc | 1 + source/blender/editors/space_view3d/space_view3d.cc | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/source/blender/editors/space_buttons/space_buttons.cc b/source/blender/editors/space_buttons/space_buttons.cc index 5ba94eca019..9693691f2c1 100644 --- a/source/blender/editors/space_buttons/space_buttons.cc +++ b/source/blender/editors/space_buttons/space_buttons.cc @@ -726,6 +726,7 @@ static void buttons_area_listener(const wmSpaceTypeListenerParams *params) buttons_area_redraw(area, BCONTEXT_PHYSICS); /* Needed to refresh context path when changing active particle system index. */ buttons_area_redraw(area, BCONTEXT_PARTICLE); + ED_area_tag_redraw(area); break; case ND_DRAW_ANIMVIZ: buttons_area_redraw(area, BCONTEXT_OBJECT); diff --git a/source/blender/editors/space_view3d/space_view3d.cc b/source/blender/editors/space_view3d/space_view3d.cc index 138fe99c718..f932da52284 100644 --- a/source/blender/editors/space_view3d/space_view3d.cc +++ b/source/blender/editors/space_view3d/space_view3d.cc @@ -1594,11 +1594,11 @@ static void view3d_header_region_listener(const wmRegionListenerParams *params) case NC_BRUSH: ED_region_tag_redraw(region); break; - case NC_GEOM: - if (wmn->data == ND_VERTEX_GROUP) { + case NC_GEOM: { + if (wmn->data == ND_VERTEX_GROUP || wmn->data == ND_DATA) { ED_region_tag_redraw(region); } - break; + } break; case NC_MATERIAL: /* For the canvas picker. */ if (wmn->data == ND_SHADING_LINKS) { -- 2.30.2 From 7863618b37f2ec86e71f1525756ac80fe9233c80 Mon Sep 17 00:00:00 2001 From: Amine Bensalem Date: Tue, 20 Feb 2024 14:35:00 +0100 Subject: [PATCH 2/3] Cleanup --- source/blender/editors/space_view3d/space_view3d.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/blender/editors/space_view3d/space_view3d.cc b/source/blender/editors/space_view3d/space_view3d.cc index f932da52284..0d4f808e69d 100644 --- a/source/blender/editors/space_view3d/space_view3d.cc +++ b/source/blender/editors/space_view3d/space_view3d.cc @@ -1594,11 +1594,11 @@ static void view3d_header_region_listener(const wmRegionListenerParams *params) case NC_BRUSH: ED_region_tag_redraw(region); break; - case NC_GEOM: { + case NC_GEOM: if (wmn->data == ND_VERTEX_GROUP || wmn->data == ND_DATA) { ED_region_tag_redraw(region); } - } break; + break; case NC_MATERIAL: /* For the canvas picker. */ if (wmn->data == ND_SHADING_LINKS) { -- 2.30.2 From 3bd70b4f90c36d7bef92a79c46f7c52a8f0615bb Mon Sep 17 00:00:00 2001 From: Harley Acheson Date: Tue, 19 Mar 2024 10:45:47 -0700 Subject: [PATCH 3/3] Update to current state of main. Use buttons_area_redraw --- source/blender/editors/space_buttons/space_buttons.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/blender/editors/space_buttons/space_buttons.cc b/source/blender/editors/space_buttons/space_buttons.cc index 4d3c088db0b..31db5f08769 100644 --- a/source/blender/editors/space_buttons/space_buttons.cc +++ b/source/blender/editors/space_buttons/space_buttons.cc @@ -726,7 +726,7 @@ static void buttons_area_listener(const wmSpaceTypeListenerParams *params) buttons_area_redraw(area, BCONTEXT_PHYSICS); /* Needed to refresh context path when changing active particle system index. */ buttons_area_redraw(area, BCONTEXT_PARTICLE); - ED_area_tag_redraw(area); + buttons_area_redraw(area, BCONTEXT_TOOL); break; case ND_DRAW_ANIMVIZ: buttons_area_redraw(area, BCONTEXT_OBJECT); -- 2.30.2