Use ColorPaint4f for accessing GPv3 vertex color attribute. #119694

Open
YimingWu wants to merge 1 commits from ChengduLittleA/blender:colorpaint into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

Since vertex color info in GreasePencil v3 is stored as straight alpha, this should
be exposed as ColorPaint4f (which is ColorSceneLinear4f<eAlpha::Straight>).

Note:

I'm not sure if it's desired to have ColorPaint4f as a basic type that also has
all the mixing implementations, since mixing straight alpha doesn't have
geometrical meaning.

The mixing is used inside tint/color modifiers atm, however it doesn't do alpha
mixing, it's just a straightforward interpolation, so either way they work.

Since vertex color info in GreasePencil v3 is stored as straight alpha, this should be exposed as `ColorPaint4f` (which is `ColorSceneLinear4f<eAlpha::Straight>`). Note: I'm not sure if it's desired to have `ColorPaint4f` as a basic type that also has all the mixing implementations, since mixing straight alpha doesn't have geometrical meaning. The mixing is used inside tint/color modifiers atm, however it doesn't do alpha mixing, it's just a straightforward interpolation, so either way they work.
YimingWu added the
Module
Grease Pencil
label 2024-03-20 13:07:41 +01:00
YimingWu added 1 commit 2024-03-20 13:07:50 +01:00
Hans Goudey requested changes 2024-03-20 15:23:40 +01:00
Hans Goudey left a comment
Member

Requesting changes based on conversation in chat: this change is not correct and will trigger asserts in debug builds. The attribute type is ColorGeometry4f, and that can't just be cast to ColorPaint4f. This will have to be resolved some other way.

Requesting changes based on conversation in chat: this change is not correct and will trigger asserts in debug builds. The attribute type is `ColorGeometry4f`, and that can't just be cast to `ColorPaint4f`. This will have to be resolved some other way.
This pull request has changes conflicting with the target branch.
  • source/blender/draw/intern/draw_cache_impl_grease_pencil.cc
  • source/blender/editors/sculpt_paint/grease_pencil_paint.cc
  • source/blender/modifiers/intern/MOD_grease_pencil_color.cc
  • source/blender/modifiers/intern/MOD_grease_pencil_tint.cc

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u colorpaint:ChengduLittleA-colorpaint
git checkout ChengduLittleA-colorpaint
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119694
No description provided.