Fix #119925: Mask property keyframes missing when reload the file #119961

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:119925 into main 2024-03-28 10:50:24 +01:00
Member

Caused by 6a79a6a24a

Mask AnimData is read by BKE_animdata_blend_read_data since above
commit, so BLO_read_data_address on AnimData is already done there.
However, mask_blend_read_data does it again
Similar calls to BLO_read_data_address in blend_read_data callbacks
were usually removed in 6a79a6a24a, Masks being an exception.

Accoding to @mont29 the reason while a double remapping will fail is
because there can only be one remapping from old addresses to new ones.
Once the new address has been read, this new address cannot be used as
'key' again (it will likely map to nothing, or worse, remap to something
completely unrelated!)

Caused by 6a79a6a24ab2 `Mask` `AnimData` is read by `BKE_animdata_blend_read_data` since above commit, so `BLO_read_data_address` on `AnimData` is already done there. However, `mask_blend_read_data` does it again Similar calls to `BLO_read_data_address` in `blend_read_data` callbacks were usually removed in 6a79a6a24ab2, Masks being an exception. Accoding to @mont29 the reason while a double remapping will fail is because there can only be one remapping from old addresses to new ones. Once the new address has been read, this new address cannot be used as 'key' again (it will likely map to nothing, or worse, remap to something completely unrelated!)
Philipp Oeser added 1 commit 2024-03-27 13:39:27 +01:00
Caused by 6a79a6a24a

`Mask` `AnimData` is read by `BKE_animdata_blend_read_data` since above
commit, so `BLO_read_data_address` on `AnimData` is already done there.
However, `mask_blend_read_data` does it again (and this seems to break
the reading process somehow -- or gets overwritten?).
Similar calls to `BLO_read_data_address` in `blend_read_data` callbacks
were usually removed in 6a79a6a24a, Masks being an exception.

NOTE: I am a bit on shaky ground wrt. `BLO_read_*` process, lacking
proper explanation as to why **exactly** double calls fail here.
Philipp Oeser added this to the Core project 2024-03-27 13:39:45 +01:00
Philipp Oeser added the
Interest
Animation & Rigging
label 2024-03-27 13:39:51 +01:00
Philipp Oeser requested review from Bastien Montagne 2024-03-27 13:39:57 +01:00
Bastien Montagne approved these changes 2024-03-28 03:38:06 +01:00
Bastien Montagne left a comment
Owner

Yikes... Nice candidate for 4.1.1 :(

The reason while a double remapping will fail is because there can only be one remapping from old addresses to new ones. Once the new address has been read, this new address cannot be used as 'key' again (it will likely map to nothing, or worse, remap to something completely unrelated!)

Yikes... Nice candidate for 4.1.1 :( The reason while a double remapping will fail is because there can only be one remapping from old addresses to new ones. Once the new address has been read, this new address cannot be used as 'key' again (it will likely map to nothing, or worse, remap to something completely unrelated!)
Philipp Oeser merged commit 7da9521c7c into main 2024-03-28 10:50:24 +01:00
Philipp Oeser deleted branch 119925 2024-03-28 10:50:27 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119961
No description provided.