blender/blender

Fix: File Output node always has inputs of type Color #120199

Merged

Omar Emara merged 2 commits from OmarEmaraDev/blender:fix-file-output-always-color into main

2024-04-04 09:01:30 +02:00

Omar Emara commented

2024-04-03 10:41:46 +02:00

Member

The File Output node always has inputs of type Color regardless of the
type of the connected socket. This is because the socket type update
mechanism no longer works, so the default socket type persisted.

This is a regression due to 4a4916db45, where the RNA set function no
longer allows editing socket types for built-in nodes, and the File
Output node utilized the RNA set function. To fix this, we avoid the RNA
route and set the type directly.

This fix is related to #120175 and partially fixes it, though another
fix is still necessary.

The File Output node always has inputs of type Color regardless of the type of the connected socket. This is because the socket type update mechanism no longer works, so the default socket type persisted. This is a regression due to 4a4916db45, where the RNA set function no longer allows editing socket types for built-in nodes, and the File Output node utilized the RNA set function. To fix this, we avoid the RNA route and set the type directly. This fix is related to #120175 and partially fixes it, though another fix is still necessary.

Omar Emara added the

labels 2024-04-03 10:41:46 +02:00

Omar Emara requested review from Sergey Sharybin 2024-04-03 10:42:17 +02:00

Omar Emara requested review from Jacques Lucke 2024-04-03 10:42:17 +02:00

Sergey Sharybin requested changes 2024-04-03 14:18:20 +02:00

Dismissed

Sergey Sharybin left a comment

Owner

After the fix the socket type update behaves the way it is expected to, and to me the code looks good. In a way it is more clear than using RNA API.

The PR should be targeting the main branch, as the fix is not intended to be only in 4.1.
After release is done all fixes are to be landing to main, and cherry-picked to the corrective release branch. See https://developer.blender.org/docs/handbook/release_process/release_branch/#after-a-release

After the fix the socket type update behaves the way it is expected to, and to me the code looks good. In a way it is more clear than using RNA API. The PR should be targeting the `main` branch, as the fix is not intended to be only in 4.1. After release is done all fixes are to be landing to main, and cherry-picked to the corrective release branch. See https://developer.blender.org/docs/handbook/release_process/release_branch/#after-a-release

Omar Emara changed target branch from blender-v4.1-release to main

2024-04-03 14:58:28 +02:00

Omar Emara force-pushed fix-file-output-always-color from 202327485e to ef09628e2b

2024-04-03 14:58:53 +02:00

Compare

Sergey Sharybin approved these changes 2024-04-03 15:05:57 +02:00

Jacques Lucke approved these changes 2024-04-03 16:36:24 +02:00

Jacques Lucke left a comment

Member

Generally ok.

Please also add a check if the socket type actually has to change if it's the right type already.

Generally ok. Please also add a check if the socket type actually has to change if it's the right type already.

Omar Emara added 1 commit 2024-04-04 08:59:19 +02:00

Address review 84a5400ea5

Omar Emara merged commit 79ca9e5afe into main

2024-04-04 09:01:30 +02:00

Omar Emara referenced this issue from a commit

2024-04-04 09:01:31 +02:00

Fix: File Output node always has inputs of type Color

Omar Emara deleted branch fix-file-output-always-color

2024-04-04 09:01:33 +02:00

Omar Emara referenced this issue from a commit

2024-04-09 17:12:04 +02:00

Fix: File Output node always has inputs of type Color

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Code Documentation

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120199

No description provided.