blender/blender
154
489
Fork 726
Code Issues 6.7k Pull Requests 885 Projects 18 Wiki Activity

UI: Reorganize 'Select' menus in 3D Viewport #121521

Merged
Pablo Vazquez merged 3 commits from nickberckley/blender:select-menus-3d into main 2024-05-13 16:29:30 +02:00
Conversation 3 Commits 3 Files Changed 1 +108 -98
Nika Kutsniashvili commented 2024-05-07 15:07:18 +02:00
Contributor
Copy Link

Continuing #121337
This PR reorganizes "Select" menus in 3D viewport modes to create more consistency and sort/group operators according to logic laid out in previous PR

image

General Changes:

  • Renamed all "None" options to "Deselect" as pointed out in previous PR
  • Removed "Select" from operator names where it was redundant or added where it was needed, or inconsistent with other menus
  • Exposed "Select Similar" options directly in the menu in the modes where it was not, to match Object Mode and other editors

Changes made are not as big as in previous PR and mostly consist of reordering options, so changes might difficult to see in comparisons.

Notes:

  • Curves and GPv3 options are not all implemented yet, so their menus look bit empty
  • In Mesh edit mode I left "By Attribute" in separate group, because node tools can be added in this menu and it would be good if it was grouped only to Attribute selection, and not be grouped with more operators that would make them stand out less.
  • Changes are not made to Text edit mode select menu, since it's too different and should be instead consistent with Text Editor menu

If pictures from certain modes are missing it's because changes are too little to be mentioned here and I didn't add them to avoid bloating the PR description

Object Mode

Before After
image image

Mesh Edit Mode

Before After
image image

Curve Edit Mode

Before After
image image

Surface Edit Mode

Before After
image image

Armature Edit Mode

Before After
image image

Grease Pencil (legacy) Edit Mode

Before After
image image

Mesh Paint Modes

Before After
image image

Pose Mode

Before After
image image
Continuing #121337 This PR reorganizes "Select" menus in 3D viewport modes to create more consistency and sort/group operators according to logic laid out in previous PR ![image](/attachments/8841296e-7898-4e3b-aa8a-45cb236f27be) General Changes: - Renamed all "None" options to "Deselect" as pointed out in previous PR - Removed "Select" from operator names where it was redundant or added where it was needed, or inconsistent with other menus - Exposed "Select Similar" options directly in the menu in the modes where it was not, to match Object Mode and other editors Changes made are not as big as in previous PR and mostly consist of reordering options, so changes might difficult to see in comparisons. Notes: - Curves and GPv3 options are not all implemented yet, so their menus look bit empty - In Mesh edit mode I left "By Attribute" in separate group, because node tools can be added in this menu and it would be good if it was grouped only to Attribute selection, and not be grouped with more operators that would make them stand out less. - Changes are not made to Text edit mode select menu, since it's too different and should be instead consistent with Text Editor menu If pictures from certain modes are missing it's because changes are too little to be mentioned here and I didn't add them to avoid bloating the PR description ---- **Object Mode** | Before | After | | -------- | -------- | | ![image](/attachments/11723f47-72f7-4122-9063-e5650127f706) | ![image](/attachments/857812ac-2b34-4401-b464-9ff5e56f9e4c) | --- **Mesh Edit Mode** | Before | After | | -------- | -------- | | ![image](/attachments/9910be93-8f4c-4a8b-ad38-cfd58b6bc5f0) | ![image](/attachments/82003a0b-da0d-4a4e-8c2f-d8c49ea787e4) | --- **Curve Edit Mode** | Before | After | | -------- | -------- | | ![image](/attachments/74137ebb-dc08-4454-844a-2f405fbccb3b) | ![image](/attachments/358a7acc-45f6-4017-baf7-2f06a6b4e117) | --- **Surface Edit Mode** | Before | After | | -------- | -------- | | ![image](/attachments/71dc0be2-b9d8-4708-9a08-dadbd9559bff) | ![image](/attachments/8b49aca4-4079-47cd-bf39-2997da3eb88f) | --- **Armature Edit Mode** | Before | After | | -------- | -------- | | ![image](/attachments/3f238ae6-1b4e-4443-98c7-fb1236c45a67) | ![image](/attachments/9119716e-8bd3-4cbc-913a-4355c082a96d) | --- **Grease Pencil (legacy) Edit Mode** | Before | After | | -------- | -------- | | ![image](/attachments/6881aa5d-38c5-47a2-b7fc-350c5bb65ad5) | ![image](/attachments/ab27c6e2-8ccf-46cb-ad09-56426e631bc3) | --- **Mesh Paint Modes** | Before | After | | -------- | -------- | | ![image](/attachments/638fbd9c-d7b4-4d6f-af46-21c73a4c8fb3) | ![image](/attachments/c6732444-932e-4ae7-8731-b1b601eaaefc) | --- **Pose Mode** | Before | After | | -------- | -------- | | ![image](/attachments/794ef74d-acad-40ce-8ea8-bfbb9108d8be) | ![image](/attachments/6a05a4c2-e38e-4d8b-908b-9593164db0c5) |
image.png
20 KiB
image.png
24 KiB
image.png
13 KiB
image.png
29 KiB
image.png
19 KiB
image.png
20 KiB
image.png
18 KiB
image.png
19 KiB
image.png
18 KiB
image.png
19 KiB
image.png
21 KiB
image.png
21 KiB
image.png
23 KiB
image.png
19 KiB
image.png
20 KiB
image.png
19 KiB
image.png
14 KiB
image.png
19 KiB
image.png
18 KiB
image.png
19 KiB
image.png
17 KiB
image.png image.png image.png image.png
❤️ 5
Nika Kutsniashvili added 1 commit 2024-05-07 15:07:28 +02:00
Nika Kutsniashvili added 1 commit 2024-05-07 15:08:28 +02:00
Pablo Vazquez added the
Module
User Interface
 label 2024-05-07 15:13:38 +02:00
Pablo Vazquez added this to the User Interface project 2024-05-07 15:13:43 +02:00
Nika Kutsniashvili added 1 commit 2024-05-08 15:52:27 +02:00
Nika Kutsniashvili commented 2024-05-08 15:52:55 +02:00
Author
Contributor
Copy Link

Updated PR to rename from "Deselect" back to "None" as agreed in UI module meeting.

Updated PR to rename from "Deselect" back to "None" as agreed in UI module meeting.
👍 1
Pablo Vazquez approved these changes 2024-05-13 16:24:15 +02:00
Pablo Vazquez left a comment
Member
Copy Link

So much better. Thanks!

So much better. Thanks!
Pablo Vazquez merged commit 4dbca26b5c into main 2024-05-13 16:29:30 +02:00
Pablo Vazquez deleted branch select-menus-3d 2024-05-13 16:29:32 +02:00
tintwotin commented 2024-05-20 21:04:31 +02:00
First-time contributor
Copy Link

@pablovazquez
Since the name of the main menu is Select, repeating that word is maybe redundant (red) in the menu entries?

Ex. (green lines are where the Select word is already removed)
image

@pablovazquez Since the name of the main menu is Select, repeating that word is maybe redundant (red) in the menu entries? Ex. (green lines are where the Select word is already removed) ![image](/attachments/57f28af5-9393-409c-8dfb-bd42ae80f294)
image.png
21 KiB
👍 1
michael knubben commented 2024-05-30 18:05:31 +02:00
First-time contributor
Copy Link

With box, circle and lasso select it’s at least the name of a tool, so there I could understand leaving it in, but I agree that it could go in the other cases.

With box, circle and lasso select it’s at least the name of a tool, so there I could understand leaving it in, but I agree that it could go in the other cases.
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
User Interface
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#121521
No description provided.
Delete Branch "nickberckley/blender:select-menus-3d"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?