Draw only on selected objects in curve draw mode. #121590

Merged
Sebastian Parborg merged 4 commits from ZedDB/blender:depth_draw_test into main 2024-05-27 13:37:47 +02:00

Implementation of the proposal in: #121535

The new "Only project onto selected" is available for GP3:
image
Curve(s) drawing:
image
And for annotations:
image

Why is this need?
At the Blender Studio we've had multiple artists run into issues when trying to draw onto surfaces, either for notes or for drawing actual geometry.

Here is a simple example where one would like to draw onto an object that has fur on it:
video
However as you can see in the video, the strokes doesn't end up when one might expect as it gets projects onto small details that makes the strokes very jagged and not nice to look at.

This new "Only project onto selected" makes it quick and easy for end users to select exactly what they want to project onto.

Implementation of the proposal in: #121535 The new "Only project onto selected" is available for GP3: ![image](/attachments/5c58905f-61fe-4a5d-8f2c-4915cb97e6bc) Curve(s) drawing: ![image](/attachments/4cc283cc-d876-4301-b4e5-30b43c4067fd) And for annotations: ![image](/attachments/d3f580f6-9895-4a6f-a08a-c24ee69b57d0) Why is this need? At the Blender Studio we've had multiple artists run into issues when trying to draw onto surfaces, either for notes or for drawing actual geometry. Here is a simple example where one would like to draw onto an object that has fur on it: [video](https://projects.blender.org/attachments/81567c72-7fb4-4122-970e-3f25a73544cf) However as you can see in the video, the strokes doesn't end up when one might expect as it gets projects onto small details that makes the strokes very jagged and not nice to look at. This new "Only project onto selected" makes it quick and easy for end users to select exactly what they want to project onto.
Author
Member

@blender-bot package linux

@blender-bot package linux
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR121590) when ready.
Author
Member

@blender-bot package linux

@blender-bot package linux
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR121590) when ready.
Sebastian Parborg force-pushed depth_draw_test from 1a691ee879 to 0c30f0111d 2024-05-14 15:44:15 +02:00 Compare
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR121590) when ready.
Sebastian Parborg force-pushed depth_draw_test from 0c30f0111d to bd00c79419 2024-05-14 16:45:24 +02:00 Compare
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR121590) when ready.
Sebastian Parborg requested review from Campbell Barton 2024-05-15 11:00:21 +02:00
Sebastian Parborg requested review from Falk David 2024-05-15 11:00:22 +02:00
Campbell Barton approved these changes 2024-05-15 15:12:23 +02:00
Sebastian Parborg changed title from WIP: Draw only on selected objects in curve draw mode. to Draw only on selected objects in curve draw mode. 2024-05-15 15:30:35 +02:00
Falk David requested changes 2024-05-15 17:51:08 +02:00
Dismissed
Falk David left a comment
Member

Looks generally fine to me, still have to test this out locally. Will also wait for the next module meeting to discuss this with others.

Looks generally fine to me, still have to test this out locally. Will also wait for the next module meeting to discuss this with others.
@ -4370,42 +4387,57 @@ static void rna_def_curve_paint_settings(BlenderRNA *brna)
};
prop = RNA_def_property(srna, "curve_type", PROP_ENUM, PROP_NONE);
RNA_def_property_flag(prop, PROP_DEG_SYNC_ONLY);
Member

Why are all these property flags needed?

Why are all these property flags needed?
Author
Member

Without these, changing the value will trigger a whole scene re-evaluation.
In some of our tests scenes with a lot of heavy modifiers, it could take up to 15 seconds to re-evaluate the scene, making it very tedious to tweak any values while trying to draw.

Because these properties do not require re-evaluating the whole scene, I added these.

Without these, changing the value will trigger a whole scene re-evaluation. In some of our tests scenes with a lot of heavy modifiers, it could take up to 15 seconds to re-evaluate the scene, making it very tedious to tweak any values while trying to draw. Because these properties do not require re-evaluating the whole scene, I added these.
Sebastian Parborg force-pushed depth_draw_test from bd00c79419 to 36ba54b3ba 2024-05-21 10:44:28 +02:00 Compare
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR121590) when ready.
Sebastian Parborg force-pushed depth_draw_test from 36ba54b3ba to 40c359f927 2024-05-22 11:00:47 +02:00 Compare
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR121590) when ready.
Falk David approved these changes 2024-05-27 13:01:03 +02:00
Sebastian Parborg merged commit 241c19a57a into main 2024-05-27 13:37:47 +02:00
Sebastian Parborg deleted branch depth_draw_test 2024-05-27 13:37:50 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#121590
No description provided.