USD Export: Added option to specify types of XForm ops written. #121627

Merged
Jesse Yurkovich merged 5 commits from CharlesWardlaw/blender:feature/usd_xform_ops into main 2024-05-21 22:33:45 +02:00

Different pipelines standardize on different XForm op setups (T-R-S, T-orient quat-S, Matrix). Having this options means that this standard can be chosen at export time instead of having to patch on load. Speaking from experience, this is a very helpful option.

Different pipelines standardize on different XForm op setups (T-R-S, T-orient quat-S, Matrix). Having this options means that this standard can be chosen at export time instead of having to patch on load. Speaking from experience, this is a very helpful option.
Charles Wardlaw added 1 commit 2024-05-09 17:12:13 +02:00
Charles Wardlaw requested review from Jesse Yurkovich 2024-05-09 17:12:26 +02:00
Charles Wardlaw requested review from Michael Kowalski 2024-05-09 17:12:34 +02:00
Charles Wardlaw added this to the USD project 2024-05-09 17:12:53 +02:00
Charles Wardlaw added 1 commit 2024-05-09 17:36:25 +02:00
Charles Wardlaw added 1 commit 2024-05-09 18:46:56 +02:00
Jesse Yurkovich requested changes 2024-05-15 05:38:31 +02:00
Dismissed
@ -12,3 +12,3 @@
class USDTransformWriter : public USDAbstractWriter {
private:
pxr::UsdGeomXformOp xformOp_;
std::vector<pxr::UsdGeomXformOp> xformOps_;

Use blender::Vector for this and can this variable be removed entirely? It only seems to be used inside set_xform_ops now and I believe USDTransformWriter::do_write is only called once so there's no need to have it as a member I think.

Use `blender::Vector` for this and can this variable be removed entirely? It only seems to be used inside `set_xform_ops` now and I believe `USDTransformWriter::do_write` is only called once so there's no need to have it as a member I think.
CharlesWardlaw marked this conversation as resolved
Charles Wardlaw added 1 commit 2024-05-21 17:17:35 +02:00
Jesse Yurkovich requested changes 2024-05-21 19:29:44 +02:00
Dismissed
Jesse Yurkovich left a comment
Member

Looks and runs good, just 1 quick nit though and we'll get this in.

Looks and runs good, just 1 quick nit though and we'll get this in.
@ -130,0 +148,4 @@
xformOps.append(xf.AddTransformOp());
break;
default:
printf("Warning: unknown XformOp type\n");

Replace this printf with a CLOG_WARN

Replace this printf with a CLOG_WARN
CharlesWardlaw marked this conversation as resolved
Charles Wardlaw added 1 commit 2024-05-21 21:07:36 +02:00
Swapping printf for CLOG_WARN.
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
c39b338504

@blender-bot build

@blender-bot build
Jesse Yurkovich approved these changes 2024-05-21 22:19:53 +02:00
Jesse Yurkovich merged commit 36f1a4f94f into main 2024-05-21 22:33:45 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#121627
No description provided.