Fix #102872: Custom Normals Average operator ui shows wrong properties #121864

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:102872 into main 2024-05-21 10:38:26 +02:00
Member

Weight & Threshold sliders should not show in case of Type :
Custom Normal and should show for both Type : Face Area &
Type : Corner Angle

In code, it looks like we are gathering loop_weight with val.

  • this is always 1.0 for EDBM_CLNOR_AVERAGE_LOOP
  • this is taken from BM_face_calc_area for
    EDBM_CLNOR_AVERAGE_FACE_AREA
  • this is taken from BM_loop_calc_face_angle for
    EDBM_CLNOR_AVERAGE_ANGLE

Code then compares not equal those values with given threshold, but for
EDBM_CLNOR_AVERAGE_LOOP this will never trigger (since all values are
the same), thus count is always zero which makes the effective
n_weight always 1. So all loop split normals are averaged for a vertex
with the same weight (seems to make sense to me -- at is just plain
average)

Long story short: the condition to show Weight & Threshold sliders
is just flipped (these only apply for the methods that take neighbor
faces into account).

`Weight` & `Threshold` sliders should **not** show in case of `Type` : `Custom Normal` and **should** show for both `Type` : `Face Area` & `Type` : `Corner Angle` In code, it looks like we are gathering `loop_weight` with `val`. - this is always 1.0 for `EDBM_CLNOR_AVERAGE_LOOP` - this is taken from `BM_face_calc_area` for `EDBM_CLNOR_AVERAGE_FACE_AREA` - this is taken from `BM_loop_calc_face_angle` for `EDBM_CLNOR_AVERAGE_ANGLE` Code then compares not equal those values with given threshold, but for `EDBM_CLNOR_AVERAGE_LOOP` this will never trigger (since all values are the same), thus `count` is always zero which makes the effective `n_weight` always 1. So all loop split normals are averaged for a vertex with the same weight (seems to make sense to me -- at is just plain average) Long story short: the condition to show `Weight` & `Threshold` sliders is just flipped (these only apply for the methods that take neighbor faces into account).
Philipp Oeser added 1 commit 2024-05-16 13:00:37 +02:00
`Weight` & `Threshold` sliders should **not** show in case of `Type` :
`Custom Normal` and **should** show for both `Type` : `Face Area` &
`Type` : `Corner Angle`

In code, it looks like we are gathering `loop_weight` with `val`.
- this is always 1.0 for `EDBM_CLNOR_AVERAGE_LOOP`
- this is taken from `BM_face_calc_area` for
`EDBM_CLNOR_AVERAGE_FACE_AREA`
- this is taken from `BM_loop_calc_face_angle` for
`EDBM_CLNOR_AVERAGE_ANGLE`

Code then compares not equal those values with given threshold, but for
`EDBM_CLNOR_AVERAGE_LOOP` this will never trigger (since all values are
the same), thus `count` is always zero which makes the effective
`n_weight` always 1. So all loop split normals are averaged for a vertex
with the same weight (seems to make sense to me -- at is just plain
average)

Long story short: the condition to show `Weight` & `Threshold` sliders
is just flipped (these only apply for the methods that take neighbor
faces into account).
Philipp Oeser added this to the Modeling project 2024-05-16 13:00:53 +02:00
Philipp Oeser added the
Interest
User Interface
label 2024-05-16 13:01:01 +02:00
Philipp Oeser requested review from Hans Goudey 2024-05-16 13:01:08 +02:00
Philipp Oeser requested review from Campbell Barton 2024-05-16 13:01:14 +02:00
Hans Goudey approved these changes 2024-05-20 01:40:46 +02:00
Philipp Oeser merged commit 58f5b128c9 into main 2024-05-21 10:38:26 +02:00
Philipp Oeser deleted branch 102872 2024-05-21 10:38:29 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#121864
No description provided.