Refactor: Split create_index_grids() into 2 separate functions #122020

Merged
Raul Fernandez Hernandez merged 7 commits from farsthary/blender:draw_pbvh_cleanup into main 2024-05-22 18:02:12 +02:00

Refactor subtask of #121929

Simplified void create_index_grids(const PBVH_GPU_Args &args, bool do_coarse)
with 2 extra functions that account for 2 code path generating faces indices.
This increase code readability and reasoning about its behavior instead of having a single uber function.

Refactor subtask of #121929 Simplified void create_index_grids(const PBVH_GPU_Args &args, bool do_coarse) with 2 extra functions that account for 2 code path generating faces indices. This increase code readability and reasoning about its behavior instead of having a single uber function.
Raul Fernandez Hernandez added 6 commits 2024-05-20 22:05:52 +02:00
Raul Fernandez Hernandez requested review from Sergey Sharybin 2024-05-20 22:06:47 +02:00
Raul Fernandez Hernandez requested review from Hans Goudey 2024-05-20 22:06:48 +02:00
Hans Goudey approved these changes 2024-05-21 02:29:54 +02:00
Hans Goudey left a comment
Member

Thanks for splitting this off, it does help!

Thanks for splitting this off, it does help!
@ -1137,2 +1137,4 @@
}
void create_tris_from_grids(const PBVH_GPU_Args &args,
int display_gridsize,
Member

The int arguments can be const

The `int` arguments can be const
farsthary marked this conversation as resolved
Hans Goudey changed title from Refactor create_index_grids() with 2 separated functions to Refactor: Split create_index_grids() into 2 separate functions 2024-05-21 02:34:34 +02:00
Raul Fernandez Hernandez added 1 commit 2024-05-21 18:13:31 +02:00
Raul Fernandez Hernandez merged commit 304b862d28 into main 2024-05-22 18:02:12 +02:00
Raul Fernandez Hernandez deleted branch draw_pbvh_cleanup 2024-05-22 18:02:15 +02:00
Member

For the record, I mentioned to Raul in chat that I thought committing this already is okay since it's a fairly trivial cleanup.

For the record, I mentioned to Raul in chat that I thought committing this already is okay since it's a fairly trivial cleanup.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#122020
No description provided.