blender/blender
168
526
Fork 800
Code Issues 6.6k Pull Requests 954 Projects 21 Wiki Activity

Refactor: combine insert_keyframe() and insert_key_rna() into a single function #122053

Merged
Nathan Vegdahl merged 49 commits from nathanvegdahl/blender:combine_keying_functions into main 2024-06-11 16:43:08 +02:00
Conversation 8 Commits 49 Files Changed 9 +5
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 22f46f00bd - Show all commits

5
source/blender/animrig/intern/keyframing.cc
View File

@ -858,6 +858,11 @@ CombinedKeyingResult insert_keyframes(Main *bmain,
prop);
Vector<float> rna_values = get_keyframe_values(&ptr, prop, visual_keyframing);
BitVector<> successful_remaps(rna_values.size(), false);
/* NOTE: in addition to remapping, this also marks what elements of an array
* property will actually get keyed by `insert_key_action()` below via
* `successful_remaps`. Importantly, for quaternion properties it may choose
* to key all array elements regardless of the passed index parameter,
* depending on the NLA setup. */
BKE_animsys_nla_remap_keyframe_values(nla_context,
&id_pointer,
prop,