blender/blender
170
530
Fork 806
Code Issues 6.5k Pull Requests 968 Projects 21 Wiki Activity

Refactor: combine insert_keyframe() and insert_key_rna() into a single function #122053

Merged
Nathan Vegdahl merged 49 commits from nathanvegdahl/blender:combine_keying_functions into main 2024-06-11 16:43:08 +02:00
Conversation 8 Commits 49 Files Changed 9 +1 -3
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3a02ca2c0f - Show all commits

4
source/blender/animrig/intern/keyframing.cc
View File

@ -1039,9 +1039,7 @@ CombinedKeyingResult insert_keyframes(Main *bmain,
* we're faithfully reproducing the original behavior.
*/
eInsertKeyFlags insert_key_flags_adjusted = insert_key_flags;
if (force_all && rna_values.size() > 0 &&
(insert_key_flags & (INSERTKEY_REPLACE | INSERTKEY_AVAILABLE)) != 0)
{
if (force_all && insert_key_flags & (INSERTKEY_REPLACE | INSERTKEY_AVAILABLE)) {
nathanvegdahl marked this conversation as resolved Outdated
Sybren A. Stüvel commented 2024-06-11 11:39:04 +02:00
Outdated
Review
Copy Link

rna_values.size() > 0 → !rna_values.is_empty().

But actually that part of the condition can be entirely removed. The chance of rna_values actually being empty is minute (why is this function even getting called, in that case?), and so this only 'optimizes' away two numerical comparisons and an assignment to at_least_one_would_succeed.

`rna_values.size() > 0` → `!rna_values.is_empty()`. But actually that part of the condition can be entirely removed. The chance of `rna_values` actually being empty is minute (why is this function even getting called, in that case?), and so this only 'optimizes' away two numerical comparisons and an assignment to `at_least_one_would_succeed`.
👍 1
/* Determine if at least one element would succeed getting keyed. */
nathanvegdahl marked this conversation as resolved Outdated
Sybren A. Stüvel commented 2024-06-11 11:43:49 +02:00
Outdated
Review
Copy Link

The != 0 can be removed, which would, for me, increase the readability of this condition.

The ` != 0` can be removed, which would, for me, increase the readability of this condition.
👍 1
bool at_least_one_would_succeed = false;
for (int i = 0; i < rna_values.size(); i++) {