blender/blender
166
521
Fork 797
Code Issues 6.8k Pull Requests 947 Projects 21 Wiki Activity

Refactor: combine insert_keyframe() and insert_key_rna() into a single function #122053

Merged
Nathan Vegdahl merged 49 commits from nathanvegdahl/blender:combine_keying_functions into main 2024-06-11 16:43:08 +02:00
Conversation 8 Commits 49 Files Changed 9 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8e3a58d071 - Show all commits

6
source/blender/animrig/intern/keyframing.cc
View File

@ -930,9 +930,9 @@ CombinedKeyingResult insert_keyframes(Main *bmain,
if (combined_result.get_count(SingleKeyingResult::SUCCESS) > 0) {
DEG_id_tag_update(&action->id, ID_RECALC_ANIMATION_NO_FLUSH);
/* TODO: it's not entirely clear when the action we got won't be the same as
* the action in AnimData. Further, it's not clear why it would neet to be
* tagged for a depsgraph update regardless. This code is here because it
/* TODO: it's not entirely clear why the action we got wouldn't be the same
* as the action in AnimData. Further, it's not clear why it would need to
* be tagged for a depsgraph update regardless. This code is here because it
* was part of the function this one was refactored from, but at some point
* this should be investigated and either documented or removed. */
if (adt->action != nullptr && adt->action != action) {