Fix: Dont unpack resources that are packed in linked files (next round) #122204

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:122033_c into main 2024-05-26 11:32:18 +02:00
Member

These remain linked, so data remains to be read/loaded from the packed
version from the library (making this a useless and wasteful
duplication, also changes could be perceived as lost)

Continuation of !122092 which came up in #122033 -- but spread to more
operators / API so it is consistent everywhere

For operators, first intuition was to do it in a poll function, but that
isnt possible because the actual ID might depend on a given (to the
operator) ID name.

NOTE: Still not 100% in which scenarios linked data could still be
editable, but using ID_IS_EDITABLE for this now.

c6aa1fec2b / 918d34a9ed are related

These remain linked, so data remains to be read/loaded from the packed version from the library (making this a useless and wasteful duplication, also changes could be perceived as lost) Continuation of !122092 which came up in #122033 -- but spread to more operators / API so it is consistent everywhere For operators, first intuition was to do it in a poll function, but that isnt possible because the actual ID might depend on a given (to the operator) ID name. NOTE: Still not 100% in which scenarios linked data could still be editable, but using ID_IS_EDITABLE for this now. c6aa1fec2bc4 / 918d34a9ed15 are related
Philipp Oeser added 1 commit 2024-05-24 12:55:04 +02:00
These remain linked, so data remains to be read/loaded from the packed
version from the library (making this a useless and wasteful
duplication, also changes could be perceived as lost)

Continuation of !122092 which came up in #122033 -- but spread to more
operators / API so it is consistent everywhere

For operators, first intuition was to do it in a poll function, but that
isnt possible because the actual ID might depend on a given (to the
operator) ID name.

NOTE: Still not 100% in which scenarios linked data could still be
editable, but using ID_IS_EDITABLE for this now.

c6aa1fec2b / 918d34a9ed are related
Philipp Oeser requested review from Brecht Van Lommel 2024-05-24 12:55:19 +02:00
Philipp Oeser requested review from Bastien Montagne 2024-05-24 12:55:26 +02:00
Philipp Oeser added this to the Core project 2024-05-24 12:55:34 +02:00
Bastien Montagne approved these changes 2024-05-24 13:49:38 +02:00
Bastien Montagne left a comment
Owner

LGTM

In current main, there should be no case where a linked ID would be editable.

This is a future 'feature' required by/part of the Brush Asset project, which should land soon after Blender 4.2 moves to BCon3.

LGTM In current `main`, there should be no case where a linked ID would be editable. This is a future 'feature' required by/part of the Brush Asset project, which should land soon after Blender 4.2 moves to BCon3.
Brecht Van Lommel approved these changes 2024-05-24 15:40:48 +02:00
Philipp Oeser merged commit a65df02031 into main 2024-05-26 11:32:18 +02:00
Philipp Oeser deleted branch 122033_c 2024-05-26 11:32:20 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#122204
No description provided.