blender/blender
149
475
Fork 701
Code Issues 6.7k Pull Requests 890 Projects 18 Wiki Activity

Extensions: New status message when checking for update #122378

Merged
Dalai Felinto merged 3 commits from ideasman42/blender:pr-sync-message-update into main 2024-05-28 18:39:51 +02:00
Conversation 1 Commits 3 Files Changed 5 +8 -4
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit dd4da7748f - Show all commits

12
scripts/addons_core/bl_pkg/cli/blender_ext.py
View File

@ -1657,7 +1657,7 @@ def repo_sync_from_remote(
Load package information into the local path.
"""
request_exit = False
request_exit |= message_status(msg_fn, f'Checking repository "{remote_name}" for updates...')
request_exit |= message_status(msg_fn, "Checking repository \"{:s}\" for updates...".format(remote_name))
dfelinto marked this conversation as resolved Outdated
Campbell Barton commented 2024-05-28 16:15:55 +02:00
Outdated
Review
Copy Link

Prefer to use str.format over f-strings. Also oter strings in this PR.

Prefer to use `str.format` over f-strings. Also oter strings in this PR.
if request_exit:
return False
@ -1676,7 +1676,7 @@ def repo_sync_from_remote(
with CleanupPathsContext(files=(local_json_path_temp,), directories=()):
# TODO: time-out.
request_exit |= message_status(msg_fn, f'Refreshing extensions list for "{remote_name}"...')
request_exit |= message_status(msg_fn, "Refreshing extensions list for \"{:s}\"...".format(remote_name))
if request_exit:
return False
@ -1707,11 +1707,15 @@ def repo_sync_from_remote(
error_msg = repo_json_is_valid_or_error(local_json_path_temp)
if error_msg is not None:
message_error(msg_fn, f'Repository error: invalid manifest ({error_msg}) for repository "{remote_name}"!')
message_error(
msg_fn,
"Repository error: invalid manifest ({:s}) for repository \"{:s}\"!".format(
error_msg,
remote_name))
return False
del error_msg
request_exit |= message_status(msg_fn, f'Extensions list for "{remote_name}" updated')
request_exit |= message_status(msg_fn, "Extensions list for \"{:s}\" updated".format(remote_name))
if request_exit:
return False