Fix #122607: Geometry Nodes: Connecting deactivated viewer node via shortcut causes crash #122613

Closed
Iliya Katushenock wants to merge 1 commits from mod_moder:fix_122607 into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Fix of regression after 7be4d4f443. There is general issue in the code that was here before but didn't caused crash yet.
The code brach should handle already existed and connected viewer node only. But for some reason this did check for
some other already existed viewer to be here. Fix here is to do not depend on other node and just do early return with
correct existed viewer. Code block alos being moved upper.

Fix of regression after 7be4d4f443a82a589ec47238765fc16aa9934246. There is general issue in the code that was here before but didn't caused crash yet. The code brach should handle already existed and connected viewer node only. But for some reason this did check for some other already existed viewer to be here. Fix here is to do not depend on other node and just do early return with correct existed viewer. Code block alos being moved upper.
Iliya Katushenock added the
Interest
Geometry Nodes
label 2024-06-01 23:29:09 +02:00
Iliya Katushenock added 1 commit 2024-06-01 23:29:18 +02:00
Iliya Katushenock added this to the Nodes & Physics project 2024-06-01 23:29:21 +02:00
Iliya Katushenock requested review from Jacques Lucke 2024-06-01 23:29:35 +02:00
Member

Thanks for the patch. I committed an alternative fix that changes the behavior less and is more inline with our most recent thoughts on custom viewers: ctrl+shift+click should connect to the active viewer. With your change, it's not taken into account what the active viewer is.

Thanks for the patch. I committed an alternative fix that changes the behavior less and is more inline with our most recent thoughts on custom viewers: ctrl+shift+click should connect to the active viewer. With your change, it's not taken into account what the active viewer is.
Jacques Lucke closed this pull request 2024-06-07 13:41:29 +02:00
Iliya Katushenock deleted branch fix_122607 2024-06-07 13:46:58 +02:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#122613
No description provided.