GPv3: Add ability to pan view-port while in primitive operator. #122813

Open
casey-bianco-davis wants to merge 2 commits from casey-bianco-davis/blender:GPv3-primitive-Panning into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

This adds MMB+shift/MMB+Alt for panning, while keeping MMB to confirm.

This adds `MMB+shift`/`MMB+Alt` for panning, while keeping MMB to confirm.
casey-bianco-davis added the
Interest
Grease Pencil
Module
Grease Pencil
labels 2024-06-06 02:20:07 +02:00
casey-bianco-davis added 1 commit 2024-06-06 02:20:19 +02:00
casey-bianco-davis added this to the Grease Pencil project 2024-06-06 02:20:23 +02:00
Falk David was assigned by casey-bianco-davis 2024-06-06 02:22:55 +02:00
Falk David was unassigned by casey-bianco-davis 2024-06-06 02:25:17 +02:00
casey-bianco-davis requested review from Falk David 2024-06-06 02:26:07 +02:00
casey-bianco-davis requested review from Falk David 2024-06-06 02:26:07 +02:00

Having the ability to panning while using primitives is a nice addition, but losing the ability to confirm the strokes without using the keyword is a regression. Primitives are used in the time-consuming cleanup process and every click counts.
I suggest keeping MMB to confirm strokes like GPv2 for the user's muscle memory and using SHIFT+MMB for panning.

Having the ability to panning while using primitives is a nice addition, but losing the ability to confirm the strokes without using the keyword is a regression. Primitives are used in the time-consuming cleanup process and every click counts. I suggest keeping `MMB` to confirm strokes like GPv2 for the user's muscle memory and using `SHIFT+MMB` for panning.
Author
Member

I suggest keeping MMB to confirm strokes... and using SHIFT+MMB for panning.

I think that making confirm as easy as possible is good, but having both the panning and confirm on the same button might be problematic, as you wouldn't want to confirm when your trying to pan.

I would like to hear some other reviewers thoughts.

> I suggest keeping `MMB` to confirm strokes... and using `SHIFT+MMB` for panning. I think that making confirm as easy as possible is good, but having both the panning and confirm on the same button might be problematic, as you wouldn't want to confirm when your trying to pan. I would like to hear some other reviewers thoughts.

I agree with @mendio . If you cannot confirm with the pen, it's a regression. GP must be focused in the draw experience and every time you need put your fingers out of the pen the drawing experince is degraded.

I agree with @mendio . If you cannot confirm with the pen, it's a regression. GP must be focused in the draw experience and every time you need put your fingers out of the pen the drawing experince is degraded.
casey-bianco-davis added 1 commit 2024-06-10 20:23:27 +02:00
Merge conflict checking is in progress. Try again in few moments.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u GPv3-primitive-Panning:casey-bianco-davis-GPv3-primitive-Panning
git checkout casey-bianco-davis-GPv3-primitive-Panning
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#122813
No description provided.