Fix #122933: Enable OpenImageDenoise support on Linux ARM64 #122948

Merged
Brecht Van Lommel merged 1 commits from Fabian-Herb/blender:openimagedenoise-linux-arm64 into main 2024-06-11 19:17:11 +02:00
Contributor

Fixes the error "Error: OpenImageDenoiser is not supported on this CPU: missing SSE 4.1 support" when running on Linux ARM64

_M_ARM64 is defined on Visual Studio only, but OpenImageDenoise 2.2 works on ARM64 Linux, too. ARM64 always has NEON, so that remark was a no-op.

The check and the error message are still a bit messed up, because at the top of the call chain it is still assumed that the presence of SSE 4.1 is the only condition for denoising to work, although there are many more.

Fixes the error "Error: OpenImageDenoiser is not supported on this CPU: missing SSE 4.1 support" when running on Linux ARM64 _M_ARM64 is defined on Visual Studio only, but OpenImageDenoise 2.2 works on ARM64 Linux, too. ARM64 always has NEON, so that remark was a no-op. The check and the error message are still a bit messed up, because at the top of the call chain it is still assumed that the presence of SSE 4.1 is the only condition for denoising to work, although there are many more.
Fabian Herb added 1 commit 2024-06-09 12:26:41 +02:00
_M_ARM64 is defined on Visual Studio only, but OIDN 2.2 works on ARM64 Linux, too.
ARM64 always has NEON, so that remark was a no-op.
Iliya Katushenock added this to the Platforms, Builds Tests & Devices project 2024-06-09 12:33:29 +02:00
Iliya Katushenock added the
Module
VFX & Video
label 2024-06-09 12:33:36 +02:00
Pratik Borhade requested review from Brecht Van Lommel 2024-06-10 09:15:18 +02:00
Pratik Borhade requested review from Sergey Sharybin 2024-06-10 09:15:18 +02:00
Sergey Sharybin added
Module
Render & Cycles
and removed
Module
VFX & Video
labels 2024-06-10 11:22:18 +02:00
Sergey Sharybin approved these changes 2024-06-10 11:25:24 +02:00
Sergey Sharybin left a comment
Owner

I don't have access to Linux ARM64 currently, but the change looks reasonable to me.

To fully benefit from the OIDN on Linux ARM the COM_is_denoise_supported() also needs adjustment. Can happen as a follow-up PR. If you can take care of that, that'd be lovely!

I don't have access to Linux ARM64 currently, but the change looks reasonable to me. To fully benefit from the OIDN on Linux ARM the `COM_is_denoise_supported()` also needs adjustment. Can happen as a follow-up PR. If you can take care of that, that'd be lovely!
Brecht Van Lommel approved these changes 2024-06-10 17:47:09 +02:00
Brecht Van Lommel merged commit 45447e8b2f into main 2024-06-11 19:17:11 +02:00
Brecht Van Lommel deleted branch openimagedenoise-linux-arm64 2024-06-11 19:17:14 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#122948
No description provided.