Anim: add new keytype 'generated' styling to the Sequencer theme #123005

Manually merged

Add the color for the new keytype 'generated' to the VSE theme settings as
well.

This includes the versioning code that loads the default from the scene.
Without this, the preference would be initialised to black.

Note that the 'Blender Light' theme does not have any colors for any of the
key types, so I also didn't add the 'generated' type there.


This was reported by @nickberckley on Blender Chat.

I'll resolve the conflict with the blender version when landing. It's kinda impossibru to create a versioning PR without a conflict there.

Add the color for the new keytype 'generated' to the VSE theme settings as well. This includes the versioning code that loads the default from the scene. Without this, the preference would be initialised to black. Note that the 'Blender Light' theme does not have any colors for any of the key types, so I also didn't add the 'generated' type there. ----------- This was reported by @nickberckley on Blender Chat. I'll resolve the conflict with the blender version when landing. It's kinda impossibru to create a versioning PR without a conflict there.
Sybren A. Stüvel added this to the 4.2 LTS milestone 2024-06-10 14:18:46 +02:00
Sybren A. Stüvel added the
Module
Animation & Rigging
Priority
High
labels 2024-06-10 14:18:46 +02:00
Sybren A. Stüvel added 1 commit 2024-06-10 14:18:51 +02:00
Add the color for the new keytype 'generated' to the VSE theme settings as
well.

This includes the versioning code that loads the default from the scene.
Without this, the preference would be initialised to black.

Note that the 'Blender Light' theme does not have any colors for any of the
key types, so I also didn't add the 'generated' type there.
Sybren A. Stüvel requested review from Nathan Vegdahl 2024-06-10 14:19:08 +02:00
Nathan Vegdahl reviewed 2024-06-10 14:25:10 +02:00
@ -691,6 +691,8 @@ const bTheme U_theme_default = {
.keytype_breakdown_select = RGBA(0x54bfedff),
.keytype_jitter_select = RGBA(0x61c042ff),
.keytype_movehold_select = RGBA(0xffaf23ff),
.keytype_generated = RGBA(0x585858ff),
Member

Nit: the existing keytype colors collectively list all of their non-select colors first, and then collectively their select colors. I don't like that organization, but I think it's better to stick to it for now for consistency.

Edit: Gah, meant to start a review, and accidentally made a single comment.

Nit: the existing keytype colors collectively list all of their non-select colors first, and then collectively their select colors. I don't like that organization, but I think it's better to stick to it for now for consistency. Edit: Gah, meant to start a review, and accidentally made a single comment.
nathanvegdahl marked this conversation as resolved
Nathan Vegdahl approved these changes 2024-06-10 14:40:16 +02:00
Nathan Vegdahl left a comment
Member

Aside from that one nit that can be addressed while landing, looks good to me!

Aside from that one nit that can be addressed while landing, looks good to me!
Sybren A. Stüvel added 1 commit 2024-06-10 14:47:27 +02:00
Nathan's feedback
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
2dd90b95af
Author
Member

@blender-bot build

@blender-bot build
Sybren A. Stüvel changed target branch from main to blender-v4.2-release 2024-06-10 15:29:04 +02:00
Sybren A. Stüvel manually merged commit 3089ac97b1 into blender-v4.2-release 2024-06-10 15:29:22 +02:00
Sybren A. Stüvel deleted branch anim/keytype-generated-add-to-sequencer-theme 2024-06-10 15:29:31 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#123005
No description provided.