Fix: VSE strip thumbnails sometimes go 1px outside of boundary #123119

Aras Pranckevicius · 2024-06-12T10:59:15+02:00

2024-06-12 10:59:15 +02:00

The VSE timeline strip thumbnail code seems to have at least two issues:

Sometimes the thumbnail would go 1px outside of the right side of the strip itself. This seems to be caused by floating point inaccuracy where current thumbnail position is tracked in "fractional timeline frames" instead of some integers like pixels. The last, often clipped, thumbnail would thus spill over outside of the strip. Fixed this by making sure the last pixel column of the strip is not included into thumbnail drawing (pointless to draw there since it is always covered by strip border).

Another problem was that the first thumbnail of the strip was often incorrectly clipped and the last pixel from it was removed, and so it was leaving a pixel gap between first and other thumbnails. This was under "Set the clipping bound to show the left handle moving"
comment, where due to inclusive range check it was always causing the "clipped" part to be set to true for the first thumb.

Also while trying to untangle all of this, moved variables closer to their usage. Some of them were only used inside the thumb loop but were declared in whole function (probably coming from when it was C code).

Before the fix:

With this PR:

The VSE timeline strip thumbnail code seems to have at least two issues: Sometimes the thumbnail would go 1px outside of the right side of the strip itself. This seems to be caused by floating point inaccuracy where current thumbnail position is tracked in "fractional timeline frames" instead of some integers like pixels. The last, often clipped, thumbnail would thus spill over outside of the strip. Fixed this by making sure the last pixel column of the strip is not included into thumbnail drawing (pointless to draw there since it is always covered by strip border). Another problem was that the first thumbnail of the strip was often incorrectly clipped and the last pixel from it was removed, and so it was leaving a pixel gap between first and other thumbnails. This was under "Set the clipping bound to show the left handle moving" comment, where due to inclusive range check it was always causing the "clipped" part to be set to true for the first thumb. Also while trying to untangle all of this, moved variables closer to their usage. Some of them were only used inside the thumb loop but were declared in whole function (probably coming from when it was C code). Before the fix: ![thumbfix-annot.png](/attachments/aaf98762-c26e-423c-b93d-adbb42fa245d) With this PR: ![thumbfix-1.png](/attachments/10a0eb76-2112-4bf0-9a64-4ea0d8e00819)

thumbfix-1.png

204 KiB

thumbfix-annot.png

260 KiB

❤️ 1

Aras Pranckevicius added 1 commit 2024-06-12 10:59:25 +02:00

Fix: VSE strip thumbnails sometimes go 1px outside of boundary

buildbot/vexp-code-patch-lint Build done.

Details

buildbot/vexp-code-patch-linux-x86_64 Build done.

Details

buildbot/vexp-code-patch-windows-amd64 Build done.

Details

buildbot/vexp-code-patch-darwin-arm64 Build done.

Details

buildbot/vexp-code-patch-darwin-x86_64 Build done.

Details

buildbot/vexp-code-patch-coordinator Build done.

Details

fac39b3a01

The VSE timeline strip thumbnail code seems to have at least two issues:

Sometimes the thumbnail would go 1px outside of the right side
of the strip itself. This seems to be caused by floating point
inaccuracy where current thumbnail position is tracked in "fractional
timeline frames" instead of some integers like pixels. The last, often
clipped, thumbnail would thus spill over outside of the strip.
Fixed this by making sure the last pixel column of the strip is not
included into thumbnail drawing (pointless to draw there since
it is always covered by strip border).

Another problem was that the first thumbnail of the strip was often
incorrectly clipped and the last pixel from it was removed, and so
it was leaving a pixel gap between first and other thumbnails.
This was under "Set the clipping bound to show the left handle moving"
comment, where due to inclusive range check it was always causing
the "clipped" part to be set to true for the first thumb.

Also while trying to untangle all of this, moved variables closer
to their usage. Some of them were only used inside the thumb loop
but were declared in whole function (probably coming from when it was
C code).

Aras Pranckevicius commented

2024-06-12 10:59:50 +02:00

@blender-bot build

Aras Pranckevicius requested review from Sergey Sharybin 2024-06-12 11:01:51 +02:00

Aras Pranckevicius commented

2024-06-12 11:25:56 +02:00

Buildbot failures are the same as what is happening on 4.2 branch right now (script_load_addons and script_load_modules tests fail with python syntax error, wheee)

Buildbot failures are the same as what is happening on 4.2 branch right now (`script_load_addons` and `script_load_modules` tests fail with python syntax error, wheee)

Sergey Sharybin approved these changes 2024-06-12 12:04:38 +02:00

Aras Pranckevicius merged commit b7cd88d502 into blender-v4.2-release

2024-06-12 12:43:13 +02:00

Aras Pranckevicius referenced this issue from a commit

2024-06-12 12:43:14 +02:00

Fix: VSE strip thumbnails sometimes go 1px outside of boundary

Aras Pranckevicius deleted branch vse-thumb-crop-fix

2024-06-12 12:43:16 +02:00

tintwotin commented

2024-06-13 09:01:44 +02:00

First-time contributor

Could be the reason for this too: #118719

Could be the reason for this too: https://projects.blender.org/blender/blender/issues/118719

Aras Pranckevicius commented

2024-06-13 09:41:32 +02:00

Could be the reason for this too: #118719

Very unlikely. But on that issue, no one else could reproduce it, and you never attached files that would reproduce it either, so 🤷

> Could be the reason for this too: https://projects.blender.org/blender/blender/issues/118719 Very unlikely. But on that issue, no one else could reproduce it, and you never attached files that would reproduce it either, so 🤷

tintwotin commented

2024-06-13 11:51:14 +02:00

First-time contributor

It was very hit-and-miss. Sometimes it happened, and sometimes it did not. Sometimes it disappeared after a while. So, a file wouldn't have made any difference.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix: VSE strip thumbnails sometimes go 1px outside of boundary #123119