Fix #116138: Hidden bones cannot be active #123237

Merged

This PR modifies the check for visibility when selected in the outliner.
With the change the visibility check only affects the selection state, not the active state.
The check has also been swapped with a function call to ANIM_bone_is_visible_editbone,
so now correctly works with collection visibility.

This PR also fixes the same issue for Bone and bPoseChannel

Co-authored-by: Cedric-Hutchings

This PR modifies the check for visibility when selected in the outliner. With the change the visibility check only affects the selection state, not the active state. The check has also been swapped with a function call to `ANIM_bone_is_visible_editbone`, so now correctly works with collection visibility. This PR also fixes the same issue for `Bone` and `bPoseChannel` Co-authored-by: Cedric-Hutchings
Christoph Lendenfeld added the
Module
Animation & Rigging
label 2024-06-14 16:43:11 +02:00
Christoph Lendenfeld added 1 commit 2024-06-14 16:43:21 +02:00
Christoph Lendenfeld added 1 commit 2024-06-14 16:59:43 +02:00
Christoph Lendenfeld added 1 commit 2024-06-14 17:07:23 +02:00
Christoph Lendenfeld requested review from Sybren A. Stüvel 2024-06-14 17:07:36 +02:00
Christoph Lendenfeld added 1 commit 2024-06-18 10:46:00 +02:00
Sybren A. Stüvel requested changes 2024-06-18 11:29:12 +02:00
Dismissed
Sybren A. Stüvel left a comment
Member

That's a nice cleanup :)

I can still get the 'active' status to get lost on hiding, when I do it via the Outliner:

image

  1. Click on the bone (can be done in the outliner too) to make it selected + active.
  2. Click on the 'monitor' icon twice, to hide & show it.
  3. Bone is no longer active.

Update: I tested this in edit mode, but it applies equally to pose mode.

That's a nice cleanup :) I can still get the 'active' status to get lost on hiding, when I do it via the Outliner: ![image](/attachments/dae73fef-3b9b-48c2-9503-7e092a713c6c) 1. Click on the bone (can be done in the outliner too) to make it selected + active. 2. Click on the 'monitor' icon twice, to hide & show it. 3. Bone is no longer active. Update: I tested this in edit mode, but it applies equally to pose mode.
Author
Member

@dr.sybren I can't reproduce that. But I think you are coming across the same thing that confused me for a while.

While hidden things can be active, they can't be selected. This applies to objects and now to bones as well.
So when you hide the bone, it will lose its selection state, thus no longer being visibly highlighted. I say visibly, because the wire color IS different. But only very slightly. (the active but not selected color is a mix of unselected + active, is easier to see with a different color set)

I verified that the bone stays active using python

@dr.sybren I can't reproduce that. But I think you are coming across the same thing that confused me for a while. While hidden things can be active, they can't be selected. This applies to objects and now to bones as well. So when you hide the bone, it will lose its selection state, thus no longer being visibly highlighted. I say visibly, because the wire color IS different. But only very slightly. (the active but not selected color is a mix of unselected + active, is easier to see with a different color set) I verified that the bone stays active using python
Sybren A. Stüvel approved these changes 2024-06-18 13:46:05 +02:00
Sybren A. Stüvel left a comment
Member

I think you are coming across the same thing that confused me for a while.

You're right.

> I think you are coming across the same thing that confused me for a while. You're right.
Christoph Lendenfeld merged commit 1ab66a6b4f into blender-v4.2-release 2024-06-18 13:54:48 +02:00
Christoph Lendenfeld deleted branch fix_hidden_bones_cant_be_active 2024-06-18 13:54:55 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#123237
No description provided.