blender/blender
165
520
Fork 796
Code Issues 6.8k Pull Requests 949 Projects 21 Wiki Activity

Anim: add "legacy behavior" option to Limit Rotation constraint #123361

Merged
Nathan Vegdahl merged 5 commits from nathanvegdahl/blender:fix_123105_limit_rotation into blender-v4.2-release 2024-06-18 18:29:37 +02:00
Conversation 2 Commits 5 Files Changed 6 +77 -11
Nathan Vegdahl commented 2024-06-18 11:27:56 +02:00
Member
Copy Link

This adds a "Legacy Behavior" option to the Limit Rotation constraint that makes
it behave how Limit Rotation constraints did prior to
ed2408400d. Newly created constraints have this
option disabled, but versioning code enables the option on constraints from
older files to ensure that the behavior of e.g. existing rigs is not altered.

This is one part of a two-part fix for #123105. The other part is in PR
extensions/rigify#4.

This adds a "Legacy Behavior" option to the Limit Rotation constraint that makes it behave how Limit Rotation constraints did prior to ed2408400d53e943cb6c97db10f12cf6729ef089. Newly created constraints have this option disabled, but versioning code enables the option on constraints from older files to ensure that the behavior of e.g. existing rigs is not altered. This is one part of a two-part fix for #123105. The other part is in PR extensions/rigify#4.
Nathan Vegdahl added 1 commit 2024-06-18 11:28:04 +02:00
Nathan Vegdahl changed title from Anim: add "legacy behavior" option to Limit Rotation constraint to WIP: Anim: add "legacy behavior" option to Limit Rotation constraint 2024-06-18 11:31:38 +02:00
Nathan Vegdahl added the
Module
Animation & Rigging
 label 2024-06-18 11:31:49 +02:00
Nathan Vegdahl added 1 commit 2024-06-18 14:43:56 +02:00
Nathan Vegdahl added 1 commit 2024-06-18 14:57:44 +02:00
Nathan Vegdahl changed title from WIP: Anim: add "legacy behavior" option to Limit Rotation constraint to Anim: add "legacy behavior" option to Limit Rotation constraint 2024-06-18 15:09:22 +02:00
Nathan Vegdahl requested review from Christoph Lendenfeld 2024-06-18 15:09:47 +02:00
Nathan Vegdahl requested review from Sybren A. Stüvel 2024-06-18 15:09:54 +02:00
Nathan Vegdahl changed target branch from main to blender-v4.2-release 2024-06-18 15:11:03 +02:00
Christoph Lendenfeld approved these changes 2024-06-18 16:20:58 +02:00
Christoph Lendenfeld left a comment
Member
Copy Link

lgtm

I like the term "legacy behavior". Clearly tells me that this isn't something I should really be using

lgtm I like the term "legacy behavior". Clearly tells me that this isn't something I should really be using
Sybren A. Stüvel approved these changes 2024-06-18 16:57:01 +02:00
Sybren A. Stüvel left a comment
Member
Copy Link

LGTM, just one superficial note.

LGTM, just one superficial note.
source/blender/blenkernel/intern/constraint.cc Outdated
@ -1766,0 +1764,4 @@
if (data->flag & LIMIT_ROT_LEGACY_BEHAVIOR) {
/* The legacy behavior that doesn't understand that rotations loop around,
* and is thus effectively "broken" in the general case. See issues #117927
* and #123105 for details. */
Sybren A. Stüvel commented 2024-06-18 16:56:51 +02:00
Member
Copy Link

Probably a good idea to add a bit more detail here, then point people here from the LIMIT_ROT_LEGACY_BEHAVIOR definition comment.

Probably a good idea to add a bit more detail here, then point people here from the `LIMIT_ROT_LEGACY_BEHAVIOR` definition comment.
nathanvegdahl marked this conversation as resolved
Sybren A. Stüvel commented 2024-06-18 16:57:42 +02:00
Member
Copy Link

This adds a "Legacy Behavior" option to the Limit Rotation constraint that makes
it behave how Limit Rotation constraints did prior to #118502.

Replace #118502 with the commit hash, in the commit message. That way the reference can be understood locally.

> This adds a "Legacy Behavior" option to the Limit Rotation constraint that makes > it behave how Limit Rotation constraints did prior to #118502. Replace `#118502` with the commit hash, in the commit message. That way the reference can be understood locally.
👍 1
Nathan Vegdahl added 1 commit 2024-06-18 17:51:56 +02:00
Flesh out explanatory comment
All checks were successful
buildbot/vexp-code-patch-lint Build done.
Details
buildbot/vexp-code-patch-linux-x86_64 Build done.
Details
buildbot/vexp-code-patch-windows-amd64 Build done.
Details
buildbot/vexp-code-patch-coordinator Build done.
Details
3dee709ccc
Nathan Vegdahl commented 2024-06-18 17:56:28 +02:00
Author
Member
Copy Link

@blender-bot build

@blender-bot build
Nathan Vegdahl added 1 commit 2024-06-18 18:28:19 +02:00 
In accordance with the coding style guidelines.
Nathan Vegdahl merged commit 295df94478 into blender-v4.2-release 2024-06-18 18:29:37 +02:00
Nathan Vegdahl deleted branch fix_123105_limit_rotation 2024-06-18 18:29:39 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Christoph Lendenfeld
Sybren A. Stüvel
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Code Documentation
Code comments, Python/RNA API descriptions

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/

  
Module
Animation & Rigging

  
Module
Asset System

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#123361
No description provided.
Delete Branch "nathanvegdahl/blender:fix_123105_limit_rotation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?