Fix #123266: Screw modifier does not propagate edge custom data #123364

Open
Philipp Oeser wants to merge 1 commits from lichtwerk/blender:123266 into blender-v4.2-release

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

No response

_No response_
Philipp Oeser added 1 commit 2024-06-18 12:23:02 +02:00
Fix #123266: Screw modifier does not propagate edge custom data
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
3bd92992a4
Philipp Oeser requested review from Hans Goudey 2024-06-18 12:23:16 +02:00
Philipp Oeser added this to the Modeling project 2024-06-18 12:23:21 +02:00
Author
Member

@blender-bot build

@blender-bot build
Hans Goudey reviewed 2024-06-18 21:01:47 +02:00
Hans Goudey left a comment
Member

Technically this isn't backwards compatible-- it could change the results in procedural situations where users depended on the default values on the edge domain. Personally I would skip this, as part of the "don't change modifiers, just slowly transition to nodes" idea. But I could be convinced the other way too.

Technically this isn't backwards compatible-- it could change the results in procedural situations where users depended on the default values on the edge domain. Personally I would skip this, as part of the "don't change modifiers, just slowly transition to nodes" idea. But I could be convinced the other way too.
First-time contributor

It feels really awkward for how Screw handles this now, especially when Solidify is fine with attributes after extrusion.
It has the same bad user experience as inconsistent normals (for that case we have Calculate Order or Flip in Normals rollout). Just add another single checkbox "propagate edge data" for compatibility...

"don't change modifiers, just slowly transition to nodes"

This could take years.

It feels really awkward for how Screw handles this now, especially when Solidify is fine with attributes after extrusion. It has the same bad user experience as inconsistent normals (for that case we have Calculate Order or Flip in Normals rollout). Just add another single checkbox "propagate edge data" for compatibility... >"don't change modifiers, just slowly transition to nodes" This could take years.
Author
Member

Just add another single checkbox "propagate edge data" for compatibility...

@HooglyBoogly : would you be fine with that?

> Just add another single checkbox "propagate edge data" for compatibility... @HooglyBoogly : would you be fine with that?
Author
Member

Technically this isn't backwards compatible-- it could change the results in procedural situations where users depended on the default values on the edge domain. Personally I would skip this, as part of the "don't change modifiers, just slowly transition to nodes" idea. But I could be convinced the other way too.

My personal take on this is:

  • if we consider this "better" design / "the correct thing to do" in nodes, then we should go ahead and fix this in modifiers as well (esp. if there are PRs for that on the table). This just gives a good example for when the modifier gets ported, raises the bar for everything else in blender as well (be it tools/operators/nodes), gives another example of "propagate/interpolate custom data everywhere as much as possible"
> Technically this isn't backwards compatible-- it could change the results in procedural situations where users depended on the default values on the edge domain. Personally I would skip this, as part of the "don't change modifiers, just slowly transition to nodes" idea. But I could be convinced the other way too. My personal take on this is: - if we consider this "better" design / "the correct thing to do" in nodes, then we should go ahead and fix this in modifiers as well (esp. if there are PRs for that on the table). This just gives a good example for when the modifier gets ported, raises the bar for everything else in blender as well (be it tools/operators/nodes), gives another example of "propagate/interpolate custom data everywhere as much as possible"
First-time contributor

A checkbox for compatibility seems like a good way to go. I also don't see much benefit in waiting a potentially long time for a node version when a fix is readily available.

A checkbox for compatibility seems like a good way to go. I also don't see much benefit in waiting a potentially long time for a node version when a fix is readily available.
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
Merge conflict checking is in progress. Try again in few moments.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 123266:lichtwerk-123266
git checkout lichtwerk-123266
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#123364
No description provided.