Fix #123332: VSE strip transform handles look tweaks #123391

Aras Pranckevicius · 2024-06-18T18:10:22+02:00

2024-06-18 18:10:22 +02:00

Current look of VSE timeline view strip transformation handles makes them somewhat "too narrow", especially after recent changes that made them more narrow than before (handle tweaking feature) and a strip visual change that made strip outline not go outside of strip bounds. They are now just 2px wide, effectively.

This changes their look as outlined in #123332 design task:

The inset dark line is no longer over the handles, but rather "inside" of them (except when handles are semitransparent, i.e. for strips that are not selected).
The handles themselves have rounded corners.

Default "new way" of handle tweaking:

The "old way" of handle tweaking:

Current look of VSE timeline view strip transformation handles makes them somewhat "too narrow", especially after recent changes that made them more narrow than before (handle tweaking feature) and a strip visual change that made strip outline not go outside of strip bounds. They are now just 2px wide, effectively. This changes their look as outlined in #123332 design task: - The inset dark line is no longer over the handles, but rather "inside" of them (except when handles are semitransparent, i.e. for strips that are not selected). - The handles themselves have rounded corners. Default "new way" of handle tweaking: ![Screenshot 2024-06-18 at 12.45.26.png](/attachments/555e071c-34da-468e-9de1-9cc51bb9c098) The "old way" of handle tweaking: ![Screenshot 2024-06-18 at 15.20.09.png](/attachments/0bba2582-2700-4821-b5ff-87dd1c6af4f1)

Aras Pranckevicius added 2 commits 2024-06-18 18:10:34 +02:00

Fix #123333 : VSE strip outline width takes DPI/line width setting into account 8f3da368fc

Now the strip outline (1 point for unselected strips, 2 point outline +
1 pt dark inset) takes monitor DPI / user preference line width into
account, via the usual U.pixelsize machinery.

Fix #123332 : VSE strip transform handles look

buildbot/vexp-code-patch-lint Build done.

Details

buildbot/vexp-code-patch-darwin-arm64 Build done.

Details

buildbot/vexp-code-patch-darwin-x86_64 Build done.

Details

buildbot/vexp-code-patch-linux-x86_64 Build done.

Details

buildbot/vexp-code-patch-windows-amd64 Build done.

Details

buildbot/vexp-code-patch-coordinator Build done.

Details

b37b024df3

Current look of VSE timeline view strip transformation handles makes
them somewhat "too narrow", especially after recent changes that
made them more narrow than before (handle tweaking feature) and
a strip visual change that made strip outline not go outside of strip
bounds. They are now just 2px wide, effectively.

This changes their look as outlined in #123332 design task:
- The inset dark line is no longer over the handles, but rather
  "inside" of them (except when handles are semitransparent, i.e.
  for strips that are not selected).
- The handles themselves have rounded corners.

Aras Pranckevicius commented

2024-06-18 18:10:54 +02:00

@blender-bot package

Blender Bot commented

2024-06-18 18:10:58 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR123391) when ready.

Aras Pranckevicius referenced this pull request

2024-06-18 18:11:15 +02:00

VSE: Thicker strip handles on selection #123332

Francesco Siddi commented

2024-06-18 20:22:22 +02:00

Looking great. Only one request: would it be possible to match the inner outline handle color (white and yellow) when transforming a strip? Currently the color remains off-white, or orange.

Current	Proposed

Looking great. Only one request: would it be possible to match the inner outline handle color (white and yellow) when transforming a strip? Currently the color remains off-white, or orange. | Current | Proposed | |----|-----| | ![handle.png](/attachments/f2e7a8f6-bf9f-4965-a5be-5d46c1d53390) | ![handle_desired.png](/attachments/918c300a-9b7a-4b74-817f-353cb14145a0) |

handle.png

102 KiB

handle_desired.png

103 KiB

Aras Pranckevicius commented

2024-06-18 21:31:17 +02:00

Only one request: would it be possible to match the inner outline handle color (white and yellow) when transforming a strip?

Of course. Right now it is behaving "as previously" (e.g. in Blender 4.0 or similar). I was curious why the colors were not matching exactly while transforming, but I thought that's intentional. I can make them match indeed.

> Only one request: would it be possible to match the inner outline handle color (white and yellow) when transforming a strip? Of course. Right now it is behaving "as previously" (e.g. in Blender 4.0 or similar). I was curious why the colors were not matching exactly while transforming, but I thought that's intentional. I can make them match indeed.

❤️ 1

Aras Pranckevicius added 2 commits 2024-06-19 09:05:38 +02:00

VSE: further handle color tweaks a1165588d1

Selected handles always use the same color as the outline. Previously
they were almost always using it, except while actively transforming -
the outline was brighter but the handle itself was not.

With this, there's no need for handle colors state for the shader,
it is enough to put in flags which handles are selected vs which
ones are merely drawn.

Merge branch 'blender-v4.2-release' into vse_handles_look

buildbot/vexp-code-patch-darwin-x86_64 Build done.

Details

buildbot/vexp-code-patch-darwin-arm64 Build done.

Details

buildbot/vexp-code-patch-lint Build done.

Details

buildbot/vexp-code-patch-linux-x86_64 Build done.

Details

buildbot/vexp-code-patch-windows-amd64 Build done.

Details

buildbot/vexp-code-patch-coordinator Build done.

Details

6945104304

Aras Pranckevicius commented

2024-06-19 09:07:14 +02:00

@blender-bot package

Blender Bot commented

2024-06-19 09:07:17 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR123391) when ready.

tintwotin commented

2024-06-19 09:58:49 +02:00

First-time contributor

The should the warning red-out-line, be on top of the handle, or under, or should the handle even go red?

I don't know if it is related to this patch, but thumbnails seem to snap outside the strip?

The should the warning red-out-line, be on top of the handle, or under, or should the handle even go red? I don't know if it is related to this patch, but thumbnails seem to snap outside the strip?

thumbs_snap.gif

131 KiB

Aras Pranckevicius commented

2024-06-19 10:33:03 +02:00

The should the warning red-out-line, be on top of the handle, or under

If you are testing build from today (finished very recently), then both outline and the handle should be red together.

or should the handle even go red?

I don't know, but sounds unrelated to this PR (both before and after this PR the outline does get red)

I don't know if it is related to this patch, but thumbnails seem to snap outside the strip?

I'd say 99% chance that this is unrelated to this PR (i.e. this PR does nothing whatsover about thumbnails). This looks like a bug, but from a quick try I can't reproduce it. A bug report with more details in how to make it happen would be useful.

> The should the warning red-out-line, be on top of the handle, or under If you are testing build from today (finished very recently), then both outline and the handle should be red together. > or should the handle even go red? I don't know, but sounds unrelated to this PR (both before and after this PR the outline does get red) > I don't know if it is related to this patch, but thumbnails seem to snap outside the strip? I'd say 99% chance that this is unrelated to this PR (i.e. this PR does nothing whatsover about thumbnails). This looks like a bug, but from a quick try I can't reproduce it. A bug report with more details in how to make it happen would be useful.

Aras Pranckevicius added 1 commit 2024-06-19 11:26:00 +02:00

Merge branch 'blender-v4.2-release' into vse_handles_look a1d95fb77d

# Conflicts:
#	source/blender/gpu/shaders/gpu_shader_sequencer_strips_frag.glsl

Aras Pranckevicius changed title from ~~WIP: Fix #123332: VSE strip transform handles look~~ to Fix #123332: VSE strip transform handles look

2024-06-19 11:26:35 +02:00

Aras Pranckevicius requested review from Sergey Sharybin 2024-06-19 11:26:47 +02:00

Aras Pranckevicius changed title from ~~Fix #123332: VSE strip transform handles look~~ to Fix #123332: VSE strip transform handles look tweaks

2024-06-19 11:26:55 +02:00

Sergey Sharybin approved these changes 2024-06-19 11:41:40 +02:00

Aras Pranckevicius merged commit 7e61f14a88 into blender-v4.2-release

2024-06-19 11:49:33 +02:00

Aras Pranckevicius referenced this issue from a commit

2024-06-19 11:49:33 +02:00

Fix #123332: VSE strip transform handles look tweaks

Aras Pranckevicius deleted branch vse_handles_look

2024-06-19 11:49:39 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #123332: VSE strip transform handles look tweaks #123391