I18n: Improve translations for the Node Wrangler add-on #123403

Merged
Bastien Montagne merged 3 commits from pioverfour/blender:dp_nw_i18n into blender-v4.2-release 2024-06-25 10:36:57 +02:00
Member

This PR contains changes needed to improve translations of the Node Wrangler add-on.

  • Fix message case and grammar
    While reading the UI code, I noticed many style UI improvements could be
    done.
  • Translate operator reports using rpt_()
    Operator reports that use string formatting need explicit rpt_() tags,
    otherwise translation occurs after formatting and the string is not
    found in the translation files.
  • Use proper translation contexts in the UI
    The UI translation contexts made translation impossible in many cases.

Each of these changes lives in a separate commit, more details in each
commit message.

This PR contains changes needed to improve translations of the Node Wrangler add-on. - Fix message case and grammar While reading the UI code, I noticed many style UI improvements could be done. - Translate operator reports using rpt_() Operator reports that use string formatting need explicit rpt_() tags, otherwise translation occurs after formatting and the string is not found in the translation files. - Use proper translation contexts in the UI The UI translation contexts made translation impossible in many cases. ----- Each of these changes lives in a separate commit, more details in each commit message.
Damien Picard added the
Interest
Translations
Module
User Interface
labels 2024-06-18 23:08:23 +02:00
Damien Picard requested review from Bastien Montagne 2024-06-18 23:08:51 +02:00
Damien Picard force-pushed dp_nw_i18n from 17cad91c8e to 4f815b94fa 2024-06-19 11:48:17 +02:00 Compare
Bastien Montagne requested changes 2024-06-24 16:51:39 +02:00
Dismissed
Bastien Montagne left a comment
Owner

Reports messages also should not have a final point currently.

This PR is also mixing functional changes/code refactoring with UI messages editing, I'd rather keep them in separate PRs, to make actual logic changes easier to review.

Reports messages also should not have a final point currently. This PR is also mixing functional changes/code refactoring with UI messages editing, I'd rather keep them in separate PRs, to make actual logic changes easier to review.
@ -222,3 +235,3 @@
return {'RUNNING_MODAL'}
else:
self.report({'WARNING'}, "View3D not found, cannot run operator")
self.report({'WARNING'}, "View3D not found, cannot run operator.")

No final point in reports messages. Same for all other cases below.

No final point in reports messages. Same for all other cases below.
Damien Picard force-pushed dp_nw_i18n from 4f815b94fa to 5fc8a66f07 2024-06-25 00:31:32 +02:00 Compare
Author
Member

I'd rather keep them in separate PRs,

Done, I left out the refactor and cleanup stuff, I’ll submit them again for main later.

> I'd rather keep them in separate PRs, Done, I left out the refactor and cleanup stuff, I’ll submit them again for main later.
Damien Picard force-pushed dp_nw_i18n from 5fc8a66f07 to c1321e935c 2024-06-25 00:46:21 +02:00 Compare
Damien Picard force-pushed dp_nw_i18n from c1321e935c to 284db8bd85 2024-06-25 00:55:10 +02:00 Compare
Bastien Montagne approved these changes 2024-06-25 10:36:14 +02:00
Bastien Montagne left a comment
Owner

LGTM, thanks!

LGTM, thanks!
Bastien Montagne merged commit fab15384a4 into blender-v4.2-release 2024-06-25 10:36:57 +02:00
Bastien Montagne deleted branch dp_nw_i18n 2024-06-25 10:37:02 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#123403
No description provided.