blender/blender
168
526
Fork 801
Code Issues 6.6k Pull Requests 962 Projects 21 Wiki Activity

Fix: USD import: domelight Y-up orientation #123797

Merged
Michael Kowalski merged 1 commits from makowalski/blender:usd_import_domelight_y_up into blender-v4.2-release 2024-06-27 19:07:03 +02:00
Conversation 4 Commits 1 Files Changed 1 +15
Michael Kowalski commented 2024-06-27 00:22:20 +02:00
Member
Copy Link

Added necessary rotation to convert from Y-up to Z-up when
importing USD dome lights as world materials.

To test, unzip the attached archive and load the hou_domelight_y_up.usda it contains
and compare the results with USDView.

Added necessary rotation to convert from Y-up to Z-up when importing USD dome lights as world materials. To test, unzip the attached archive and load the `hou_domelight_y_up.usda` it contains and compare the results with `USDView`.
dome_light_y_up.zip
75 MiB
Michael Kowalski added the
Interest
USD
Interest
Pipeline & IO
 labels 2024-06-27 00:22:20 +02:00
Michael Kowalski self-assigned this 2024-06-27 00:22:21 +02:00
Michael Kowalski added 1 commit 2024-06-27 00:22:30 +02:00
Fix: USD import: domelight Y-up orientation
Some checks failed
buildbot/vexp-code-patch-lint Build done.
Details
buildbot/vexp-code-patch-linux-x86_64 Build done.
Details
buildbot/vexp-code-patch-darwin-arm64 Build done.
Details
buildbot/vexp-code-patch-windows-amd64 Build done.
Details
buildbot/vexp-code-patch-darwin-x86_64 Build done.
Details
buildbot/vexp-code-patch-coordinator Build done.
Details
4050f7cc5e 
Added necessary rotation to convert from Y-up to Z-up when
importing USD dome lights as world materials.
Michael Kowalski added this to the USD project 2024-06-27 00:22:34 +02:00
Michael Kowalski requested review from Jesse Yurkovich 2024-06-27 00:22:53 +02:00
Jesse Yurkovich commented 2024-06-27 02:07:11 +02:00
Member
Copy Link

It's much better after the PR, but it looks like things are still off-axis. What is the view supposed to look like?

Notice the tilted steps/wall and a different camera view position compared to usdview:
tilt.png

It's much better after the PR, but it looks like things are still off-axis. What is the view supposed to look like? Notice the tilted steps/wall and a different camera view position compared to `usdview`: ![tilt.png](/attachments/56a46334-9079-4105-9d8c-d2cb0c8a707d)
tilt.png
1.9 MiB
Michael Kowalski commented 2024-06-27 15:40:08 +02:00
Author
Member
Copy Link

It's much better after the PR, but it looks like things are still off-axis. What is the view supposed to look like?

Notice the tilted steps/wall and a different camera view position compared to usdview:

Thanks for taking a look, @deadpin!

This is the original in Houdini:

image

This is what I get in USDView, which I think is the same as I get in Blender:

image

I wonder why yours looks different? Are you sure you have the camera selected in USDView?

> It's much better after the PR, but it looks like things are still off-axis. What is the view supposed to look like? > > Notice the tilted steps/wall and a different camera view position compared to `usdview`: Thanks for taking a look, @deadpin! This is the original in Houdini: ![image](/attachments/0d6fdf29-3f00-4f07-a237-1a23ecaed29d) This is what I get in `USDView`, which I think is the same as I get in Blender: ![image](/attachments/b1e79d76-a69c-40e9-84b0-eecab82c8f9a) I wonder why yours looks different? Are you sure you have the camera selected in `USDView`?
image.png
1.6 MiB
image.png
1.4 MiB
Michael Kowalski commented 2024-06-27 17:18:29 +02:00
Author
Member
Copy Link

@deadpin I think you need to turn off Lights->Enable Default Dome Light in USDView to fix the issue you are seeing:

image

@deadpin I think you need to turn off `Lights->Enable Default Dome Light` in `USDView` to fix the issue you are seeing: ![image](/attachments/3534c507-615e-4624-8d38-9ed3cba065b1)
image.png
861 KiB
Jesse Yurkovich approved these changes 2024-06-27 17:41:19 +02:00
Jesse Yurkovich left a comment
Member
Copy Link

Yes, that was the problem :( Thanks! I think this PR is good.

Yes, that was the problem :( Thanks! I think this PR is good.
👍 1
Michael Kowalski commented 2024-06-27 18:06:51 +02:00
Author
Member
Copy Link

@blender-bot build

@blender-bot build
Michael Kowalski merged commit b2f8f5a491 into blender-v4.2-release 2024-06-27 19:07:03 +02:00
Michael Kowalski deleted branch usd_import_domelight_y_up 2024-06-27 19:07:06 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Jesse Yurkovich
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Code Documentation
Code comments, Python/RNA API descriptions

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
FBX
FBX I/O related topics

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
glTF
glTF format I/O topics

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/

  
Module
Animation & Rigging

  
Module
Asset System

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
glTF
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
USD
Assignees
Clear assignees
No Assignees
Michael Kowalski
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#123797
No description provided.
Delete Branch "makowalski/blender:usd_import_domelight_y_up"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?