blender/blender
154
489
Fork 728
Code Issues 6.7k Pull Requests 888 Projects 18 Wiki Activity

GPv3: Python API for frame, drawing and drawing attributes #124787

Merged
Falk David merged 22 commits from filedescriptor/blender:gpv3-drawing-python-api into main 2024-07-26 16:30:21 +02:00
Conversation 3 Commits 22 Files Changed 10 +1 -9
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3acb6e4129 - Show all commits

10
source/blender/makesrna/intern/rna_grease_pencil.cc
View File

@ -243,13 +243,6 @@ static int rna_Frame_frame_number_get(PointerRNA *ptr)
return frame_number;
}
static void rna_Frame_frame_number_index_range(
PointerRNA * /*ptr*/, int *min, int *max, int * /*softmin*/, int * /*softmax*/)
{
*min = MINAFRAME;
*max = MAXFRAME;
}
static void rna_grease_pencil_layer_mask_name_get(PointerRNA *ptr, char *dst)
filedescriptor marked this conversation as resolved Outdated
Bastien Montagne commented 2024-07-23 17:29:20 +02:00
Outdated
Review
Copy Link

Not sure I understand why you need to define and use this callback?

Not sure I understand why you need to define and use this callback?
{
using namespace blender;
@ -812,8 +805,7 @@ static void rna_def_grease_pencil_frame(BlenderRNA *brna)
prop = RNA_def_property(srna, "frame_number", PROP_INT, PROP_NONE);
/* TODO: Make property editable, ensure frame number isn't already in use. */
RNA_def_property_clear_flag(prop, PROP_EDITABLE);
RNA_def_property_int_funcs(
prop, "rna_Frame_frame_number_get", nullptr, "rna_Frame_frame_number_index_range");
RNA_def_property_int_funcs(prop, "rna_Frame_frame_number_get", nullptr, nullptr);
RNA_def_property_range(prop, MINAFRAME, MAXFRAME);
RNA_def_property_ui_text(prop, "Frame Number", "The frame number in the scene");
RNA_def_property_update(prop, NC_GPENCIL | ND_DATA, "rna_grease_pencil_update");