Spreadsheet: support navigating instance trees #125293
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#125293
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "JacquesLucke/blender:spreadsheet-separate-instances"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Previously, it was not possible to see detailed information about instances in the spreadsheet. Only the attributes on the top level instances were shown. Now, all nested instances can be inspected too.
Combined with #114910 this will make inspecting more complex geometry with the spreadsheet much more feasible. It's also an important part of integrating grease pencil into geometry nodes because it makes it more obvious how layers are converted to curve instances.
The data-selection is split into two separate tree views now. One that selects the geometry from the instance tree, and one that's used to select the geometry component and domain within that geometry. We found that this works better than combining both tree views into one (we tried that in #124186).
Spreadsheet: support navigating instance trees (Alternative 2)to Spreadsheet: support navigating instance trees (alternative 2)I really like the direction of this PR, especially compared to the alternative. IMO it makes the structure a lot more clear and the individual sets easier to inspect.
One thought is also that this scales quite nicely with the idea of having multiple geometry sets within the original data of an object in the future.
Some initial feedback without full testing:
Geometry
by default, by identifying elements by their characteristic user count.-- I'm actually not sure why exatly they have different icons here. Is that just because one is a top level set?
Yes, that's what it does currently, but there is no specific reason for that, I'm just trying different variations to see if something works.
I did a mockup for a potential geometry (set) icon:
Nice, thanks! Looks good enough to me right now, but I don't know too much about icons. Will mention it in the user interface module chat.
I added your icon to the patch. Maybe that's good enough for now and we can potentially do another pass on it separately?
I'd like to properly sign something off before we merge. This mockup was also done pretty quickly and isn't very clean. But that should be easy to redo once a design is settled on.
We should be able to do that next week.
Spreadsheet: support navigating instance trees (alternative 2)to Spreadsheet: support navigating instance treesIterated a bit more over the icon, so here is a version with overlap, proper rounding and aligned to a grid that should bring it more in line with the rest of the icon designs.
Personally I'd go with either the filled version with overlap or the non-filled without overlap. Will ask in the UI module again.
Filled
Lines
By arranging it a little differently, I think the shapes are better understood.
This way, three corners of the square are visible and the lower edge of the triangle is not aligned with the upper edge of the square.
I tried this, but it doesn't work imo. The balance is quite off.
The shape readability works well enough imo. I'ts not about the exact shapes and order anyways, just the concept.
Since this iteration got a bunch of positive feedback in the UI module let's go with this for now.
I updated the patch to include the new icon. Thanks for that!
IIRC the icon was the last piece this PR was waiting on from what we talked about.
Some additional thoughts:
One last thought/suggestion:
Since the title
Domain
wasn't a perfect fit, how about going the more generic route and calling itData
. Since this tree refers to the part of the geometry data to be inspected, that would generally make sense imo.Both works imo, so since the other things I mentioned can all be done separately anyways, I'll already approve the PR at this point.
Would be nice indeed, but at a first glance this seems to be more tricky than one would hope.. That's because this number is not a standalone label
uiBut
but part of theuiBut
of the entire item (implementation details). Good idea though, something to keep in mind.Where would you display that exactly. Seems weird to have it next to
Mesh
.Currently, I prefer
Domain
overData
...Probably worth committing the new icon separately. But I think this is ready to go in. Using "Data" as a panel label is fine with me, though not sure it's really better TBH.
@ -130,2 +130,3 @@
attributes_(other.attributes_),
almost_unique_ids_cache_(std::move(other.almost_unique_ids_cache_))
almost_unique_ids_cache_(std::move(other.almost_unique_ids_cache_)),
reference_user_counts_(std::move(other.reference_user_counts_))
These are out of order
@ -446,0 +453,4 @@
r_data.fill(0);
const Span<int> handles = this->reference_handles();
for (const int i : IndexRange(instances_num_)) {
(const handle : handles)
It wouldn't be there. What I meant was putting the same user count number we have next to the name of the geometry set in the top tree, also next to the name in the spreadsheet for the list of instances when the instance domain is selected. (so not in the bottom tree, but in the spreadsheet itself when the instance domain is selected)
From your example, every
Leaf
instance would display the user count of that geometry set.Ah, I see, will give that a try.