Geometry Nodes: PLY import node #125587

Merged
Hans Goudey merged 6 commits from Devashish-Lal/blender:gsoc/ply-import into main 2024-08-05 14:55:12 +02:00
Contributor

This commit adds a PLY format import node, part of the current Google
Summer of Code Project [0]. The importer is refactored to output a mesh,
and a node is added to wrap around the importer. The node supports error
messages from the importer. The node is hidden behind an experimental
option for now, like the others.

0: https://devtalk.blender.org/t/gsoc-2024-geometry-nodes-file-import-nodes/34482)

This commit adds a PLY format import node, part of the current Google Summer of Code Project [0]. The importer is refactored to output a mesh, and a node is added to wrap around the importer. The node supports error messages from the importer. The node is hidden behind an experimental option for now, like the others. 0: https://devtalk.blender.org/t/gsoc-2024-geometry-nodes-file-import-nodes/34482)
Devashish Lal added 2 commits 2024-07-29 00:09:13 +02:00
Iliya Katushenock added this to the Nodes & Physics project 2024-07-29 00:28:37 +02:00
Iliya Katushenock added the
Interest
Geometry Nodes
label 2024-07-29 00:28:41 +02:00
Hans Goudey changed title from PLY Import Geometry Node to Geometry Nodes: PLY import node 2024-08-05 00:47:17 +02:00
Hans Goudey requested changes 2024-08-05 01:17:32 +02:00
Dismissed
Hans Goudey left a comment
Member

Just needs some smaller tweaks, otherwise this looks good!

Just needs some smaller tweaks, otherwise this looks good!
@ -164,0 +205,4 @@
BLI_path_extension_strip(ob_name);
/* Stuff ply data into the mesh. */
Mesh *mesh = read_ply_to_mesh(import_params, ob_name);
Member

Seems return read_ply_to_mesh(import_params, ob_name); would be fine too. Same above.

Seems `return read_ply_to_mesh(import_params, ob_name);` would be fine too. Same above.
Author
Contributor

Done

Done
Devashish-Lal marked this conversation as resolved
@ -360,3 +360,3 @@
DefNode(GeometryNode, GEO_NODE_IMAGE_TEXTURE, def_geo_image_texture, "IMAGE_TEXTURE", ImageTexture, "Image Texture", "Sample values from an image texture")
DefNode(GeometryNode, GEO_NODE_IMAGE, def_geo_image, "IMAGE", InputImage, "Image", "Input image")
DefNode(GeometryNode, GEO_NODE_IMPORT_STL, 0, "IMPORT_STL", ImportSTL, "Import STL", "Import a mesh from an STL file")
DefNode(GeometryNode, GEO_NODE_IMPORT_STL, 0, "IMPORT_STL", ImportSTL, "Import STL", "Import `a mesh from an STL file")
Member

Accidentally inserted ` here?

Accidentally inserted ` here?
Author
Contributor

Oops!

Oops!
Devashish-Lal marked this conversation as resolved
@ -0,0 +33,4 @@
return;
}
PLYImportParams import_params;
Member

PLYImportParams import_params{}; to make sure the parameters are properly zero initialized

`PLYImportParams import_params{};` to make sure the parameters are properly zero initialized
Author
Contributor

Done

Done
Devashish-Lal marked this conversation as resolved
@ -0,0 +56,4 @@
params.error_message_add(type, TIP_(report->message));
}
// TODO : GeometrySet::from_pointcloud() ?
Member

Can remove this TODO now

Can remove this TODO now
Author
Contributor

Done

Done
Devashish-Lal marked this conversation as resolved
Devashish Lal added 1 commit 2024-08-05 03:31:29 +02:00
Hans Goudey reviewed 2024-08-05 03:37:45 +02:00
lib/macos_arm64 Outdated
@ -1 +1 @@
Subproject commit ea2cae98e9a61b73c6f52603d3f9a58242f789b3
Subproject commit 402db0b5b9bb3d3014b62a8faf8c296941e2010c
Member

The subproject commit made it in here somehow

The subproject commit made it in here somehow
Author
Contributor

I am not sure why, I didn't do anything. does this happen while switching branches?

I am not sure why, I didn't do anything. does this happen while switching branches?
Author
Contributor

fixed

fixed
Devashish-Lal marked this conversation as resolved
Devashish Lal added 2 commits 2024-08-05 03:43:58 +02:00
Devashish Lal added 1 commit 2024-08-05 03:45:51 +02:00
Revert "review changes"
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
117f912b47
This reverts commit 1dd19a48b4.
Hans Goudey approved these changes 2024-08-05 04:08:26 +02:00
Member

@blender-bot build

@blender-bot build
Hans Goudey merged commit f6e6f2b2d2 into main 2024-08-05 14:55:12 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#125587
No description provided.