Fix #122454: EEVEE : Volumes don't render on Nvidia sometimes #125715

Merged
Clément Foucault merged 4 commits from pragma37/blender:pull-fix-volume-phase-nv-bug into main 2024-08-02 15:58:49 +02:00
Member

The issue happens due to out_phase_img returning wrong values in eevee_surf_volume_frag.glsl.
The only workaround I've been able to find is using the same format as the other property textures.

The issue happens due to `out_phase_img` returning wrong values in `eevee_surf_volume_frag.glsl`. The only workaround I've been able to find is using the same format as the other property textures.
Miguel Pozo added the
Module
Viewport & EEVEE
Interest
EEVEE
labels 2024-07-31 16:22:19 +02:00
Miguel Pozo added 1 commit 2024-07-31 16:22:31 +02:00
Miguel Pozo requested review from Clément Foucault 2024-07-31 16:30:03 +02:00
Clément Foucault requested changes 2024-07-31 17:34:53 +02:00
Dismissed
Clément Foucault left a comment
Member

This will not work with negative anisotropy. This needs to add changes to the shader code to remap the anisotropy. But also this will clearly bias the precision. So I am unsure.

Did you try splitting the phase into 2 textures?

This will not work with negative anisotropy. This needs to add changes to the shader code to remap the anisotropy. But also this will clearly bias the precision. So I am unsure. Did you try splitting the phase into 2 textures?
Miguel Pozo added 1 commit 2024-07-31 18:37:51 +02:00
Split phase into 2 textures
Some checks failed
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
a9b65e4268
Author
Member

Did you try splitting the phase into 2 textures?

That seems to do the trick as well!

> Did you try splitting the phase into 2 textures? That seems to do the trick as well!
Author
Member

@blender-bot build +gpu

@blender-bot build +gpu
Miguel Pozo added 1 commit 2024-08-01 15:40:31 +02:00
Merge branch 'main' into pull-fix-volume-phase-nv-bug
Some checks failed
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
cd0af70c76
Author
Member

@blender-bot build +gpu

@blender-bot build +gpu
Miguel Pozo added 1 commit 2024-08-02 12:48:23 +02:00
Merge branch 'main' into pull-fix-volume-phase-nv-bug
Some checks failed
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
b95bbcd40a
Author
Member

@blender-bot build +gpu

@blender-bot build +gpu
Author
Member

The tests failed again, but I ran them locally and everything seems fine.

The tests failed again, but I ran them locally and everything seems fine.
Clément Foucault approved these changes 2024-08-02 15:58:19 +02:00
Clément Foucault merged commit 09390858ab into main 2024-08-02 15:58:49 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#125715
No description provided.