UI: Multicolor Autokeying Indicator #126344

Harley Acheson · 2024-08-15T02:24:41+02:00

Harley Acheson commented

2024-08-15 02:24:41 +02:00

Show the autokeying indicator (record button) on the Timeline header in
red when enabled. With a white outline on dark theme, or with a black
outline on light theme. The red color is user changeable.

It looks like this when using the dark theme (with white ring around the selected color)

When using the light theme the outer ring is black:

It can be made any color, or just white, or even clear:

Show the autokeying indicator (record button) on the Timeline header in red when enabled. With a white outline on dark theme, or with a black outline on light theme. The red color is user changeable. --- It looks like this when using the dark theme (with white ring around the selected color) ![dark.gif](/attachments/779db35a-fc60-4da1-8f4e-bb5586fea340) When using the light theme the outer ring is black: ![light.gif](/attachments/0bd8bf93-d393-4170-8ccd-fb0c6c07b1ab) It can be made any color, or just white, or even clear: ![image](/attachments/d21c0eb2-49ce-4e3b-a698-bab4e0ff5d54)

image.png

45 KiB

light.gif

12 KiB

dark.gif

13 KiB

❤️ 8 🎉 4

Harley Acheson added 1 commit 2024-08-15 02:24:53 +02:00

UI: Multicolor Autokeying Indicator 89e6399c8e

Show the autokeying indicator (record button) on the Timeline header in
red when enabled. With a white outline on dark theme, or with a black
outline on light theme.

Harley Acheson added this to the User Interface project 2024-08-15 02:25:39 +02:00

Harley Acheson commented

2024-08-15 02:28:50 +02:00

@dr.sybren

This is the style you wanted originally but I couldn't do at the time since it required two colors. With the recent changes to using SVG icons we can now do multicolor icons that change with the theme.

@dr.sybren This is the style you wanted originally but I couldn't do at the time since it required two colors. With the recent changes to using SVG icons we can now do multicolor icons that change with the theme.

Harley Acheson requested review from Pablo Vazquez 2024-08-15 19:44:15 +02:00

Pablo Vazquez approved these changes 2024-08-16 18:17:06 +02:00

Pablo Vazquez left a comment

Nice! I like much simpler it seems to implement this now with all the work you've done so far.

Not for this patch, but now that we have a property color to use, we could try to rethink this little guy as well soon:

Nice! I like much simpler it seems to implement this now with all the work you've done so far. Not for this patch, but now that we have a property color to use, we could try to rethink this little guy as well soon: ![viewport](/attachments/8469723d-c772-4009-926f-a03b97dc96c3)

image.png

48 KiB

❤️ 2

Harley Acheson commented

2024-08-16 18:36:38 +02:00

Not for this patch, but now that we have a property color to use, we could try to rethink this little guy as well soon:

My hope, maybe unfounded, was that if this timeline indicator was stronger like in this PR that there might be argument to removing that "Autokeying On" string in the viewport.

If not we could indicate the state in the area header along with the changing values maybe? Perhaps not with text "(auto-keyed)" but maybe just start the line with the recording indicator?

> Not for this patch, but now that we have a property color to use, we could try to rethink this little guy as well soon: My _hope_, maybe unfounded, was that if this timeline indicator was stronger like in this PR that there might be argument to removing that "Autokeying On" string in the viewport. If not we could indicate the state in the area header along with the changing values maybe? Perhaps not with text "(auto-keyed)" but maybe just start the line with the recording indicator? ![image](/attachments/087198ef-c36a-4202-8a9a-296b5eb2ff9d)

image.png

42 KiB

Pablo Vazquez commented

2024-08-16 18:55:01 +02:00

If not we could indicate the state in the area header along with the changing values maybe?

It might not be the best place either since auto-keying can happen on all kinds of actions not just the ones that have their values displayed in the header.

But again, we should discuss that separately. Since it's a global setting it could even go to the status bar, but this requires discussion. Let's go with this one little change to the icon that's already great.

> If not we could indicate the state in the area header along with the changing values maybe? It might not be the best place either since auto-keying can happen on all kinds of actions not just the ones that have their values displayed in the header. <video src="/attachments/4688f6e9-241f-4fd4-801d-c974126cea09" title="autokeying.mov" controls></video> But again, we should discuss that separately. Since it's a global setting it could even go to the status bar, but this requires discussion. Let's go with this one little change to the icon that's already great.

autokeying.mov

1.8 MiB

Harley Acheson added 2 commits 2024-08-16 22:40:25 +02:00

Merge branch 'main' of projects.blender.org:blender/blender into ColorAutoKey 1bd110bd9f

Merge branch 'main' of projects.blender.org:blender/blender into ColorAutoKey e4c9df73e4

Harley Acheson added 1 commit 2024-08-16 22:41:17 +02:00

version bump

buildbot/vexp-code-patch-lint Build done.

Details

buildbot/vexp-code-patch-linux-x86_64 Build done.

Details

buildbot/vexp-code-patch-windows-amd64 Build done.