Fix #126587: GPv3: Select less fails if all points in stroke selected #126591

Pratik Borhade · 2024-08-21T11:38:12+02:00

Pratik Borhade commented

2024-08-21 11:38:12 +02:00

Handle the case separately when end points of strokes are selected.
Always deselect them (i.e. set "true", later array values are inverted)
when executing select less operation.

Handle the case separately when end points of strokes are selected. Always deselect them (i.e. set "true", later array values are inverted) when executing select less operation.

Pratik Borhade added 1 commit 2024-08-21 11:38:20 +02:00

Fix #126587 : GPv3: Select less fails if all points in stroke selected 450f224f5b

Handle the case separately when end points of strokes are selected.
Always deselect them (i.e. set "true", later array values are inverted)
in case of select less opertion.

Pratik Borhade requested review from Falk David 2024-08-21 11:38:39 +02:00

Pratik Borhade requested review from Hans Goudey 2024-08-21 11:38:40 +02:00

Pratik Borhade added the

Module

Grease Pencil

label 2024-08-21 11:38:49 +02:00

Pratik Borhade referenced this pull request

2024-08-23 12:36:54 +02:00

GPv3: Select less not working if all points in stroke selected #126587

Falk David reviewed 2024-08-23 12:52:38 +02:00

source/blender/editors/curves/intern/curves_selection.cc Outdated

						
				@ -628,3 +637,4 @@

				      }

				      /* Handle cyclic curve case. */

				      if (cyclic[curve_i]) {

				        if (selection_typed[points.first()] != selection_typed[points.last()]) {

Falk David commented

2024-08-23 12:52:38 +02:00

might as well use first_point and last_point here now that you store it in a variable.

might as well use `first_point` and `last_point` here now that you store it in a variable.

Pratik Borhade commented

2024-08-23 13:00:56 +02:00

Can we do that in separate commit/PR? i.e. move first/last_point at the start of curves_mask.foreach_index then replace all instances of points.first()/last()
Just to avoid noise in this PR 😅

Can we do that in separate commit/PR? i.e. move `first/last_point` at the start of `curves_mask.foreach_index` then replace all instances of `points.first()/last()` Just to avoid noise in this PR 😅

Falk David commented

2024-08-23 13:08:14 +02:00

Sure :)

Pratik Borhade commented

2024-09-09 13:05:57 +02:00

Delayed, here is the PR !127344 :)