WIP: Shader: Add Artistic Conductor Fresnel type to Metallic BSDF #126871

Alaska · 2024-08-28T04:57:40+02:00

Alaska commented

2024-08-28 04:57:40 +02:00

Add a artist friendly input type (RGB color inputs) to the
Conductor Fresnel types in the Metallic BSDF node.

Add a artist friendly input type (RGB color inputs) to the Conductor Fresnel types in the Metallic BSDF node.

Alaska added 3 commits 2024-08-28 04:57:42 +02:00

Revert "Remove Artistic Conductor" a7f921a39d

This reverts commit 7eea014d29.

Fix compatability issues 117ce19ddd

Change Cycles default fresnel eca0479b3d

Alaska changed title from ~~Shader: Add Artisitc Conductor Fresnel type to Metallic BSDF~~ to WIP: Shader: Add Artisitc Conductor Fresnel type to Metallic BSDF

2024-08-28 04:57:55 +02:00

Alaska commented

2024-08-28 05:02:20 +02:00

@Sergey @weizhen and @LukasStockner just so you know about this.

In the Metallic BSDF PR, Lukas asked for this feature.
Later on Weizhen brought up concerns about this feature.
And then it was ultimately decided that the feature would be removed from the intial commit, and could be re-added after re-evaluation and a discussion with Lukas.

This PR is mainly here to make the code changes easy to access/modify if there is a desire to re-add the Artist friendly reparametrization. However as always, it's up to the Cycles team to decide if they want this, and to my knowledge the re-evaluation hasn't happened yet.

@Sergey @weizhen and @LukasStockner just so you know about this. In the Metallic BSDF PR, [Lukas asked for this feature](https://projects.blender.org/blender/blender/pulls/114958#issuecomment-1067008). Later on Weizhen brought up [concerns about this feature](https://projects.blender.org/blender/blender/pulls/114958#issuecomment-1275521). And then it was ultimately decided that the feature would be removed from the intial commit, and could be re-added after [re-evaluation and a discussion with Lukas](https://devtalk.blender.org/t/2024-08-20-render-cycles-meeting/36313). This PR is mainly here to make the code changes easy to access/modify if there is a desire to re-add the Artist friendly reparametrization. However as always, it's up to the Cycles team to decide if they want this, and to my knowledge the re-evaluation hasn't happened yet.

Sergey Sharybin commented

2024-08-28 10:51:09 +02:00

@Alaska Thanks for preparing the PR

Weizhen Huang changed title from ~~WIP: Shader: Add Artisitc Conductor Fresnel type to Metallic BSDF~~ to WIP: Shader: Add Artistic Conductor Fresnel type to Metallic BSDF

2024-09-16 20:30:51 +02:00

Weizhen Huang commented

2024-09-16 20:35:16 +02:00

We discussed in a meeting, the conclusion is that it seems confusing to have two parametrizations doing pretty much the same thing, so we don't implement this option yet.

For compatibility with other renderers using Artistic Conductor, it's possible to convert between two parameterizations. In the future when we implement thin film on metal, some functions in this mode could be needed and we will reconsider this PR, but maybe we don't have to expose it to users.

We discussed in a meeting, the conclusion is that it seems confusing to have two parametrizations doing pretty much the same thing, so we don't implement this option yet. For compatibility with other renderers using Artistic Conductor, it's possible to convert between two parameterizations. In the future when we implement thin film on metal, some functions in this mode could be needed and we will reconsider this PR, but maybe we don't have to expose it to users.

👍 1

This pull request is marked as a work in progress.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u add-artisitc-conductor:Alaska-add-artisitc-conductor

git checkout Alaska-add-artisitc-conductor

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Shader: Add Artistic Conductor Fresnel type to Metallic BSDF #126871

Checkout