Windows: Disable shader draw parameter support on certain Qualcomm GPUs #127148

Anthony Roberts · 2024-09-04T16:15:01+02:00

Anthony Roberts commented

2024-09-04 16:15:01 +02:00

This works around an issue where eevee was rendering a pure black cube in certain shader configurations in the default scene (#122837).

This only affects X Elite devices (8cx Gen3 is unaffected).

This works around an issue where eevee was rendering a pure black cube in certain shader configurations in the default scene (#122837). This only affects X Elite devices (8cx Gen3 is unaffected).

Anthony Roberts added 1 commit 2024-09-04 16:15:04 +02:00

Windows: Disable shader draw parameter support on certain Qualcomm GPUs

buildbot/vexp-code-patch-lint Build done.

Details

buildbot/vexp-code-patch-windows-arm64 Build done.

Details

buildbot/vexp-code-patch-coordinator Build done.

Details

41b00ef8b8

This works around an issue where eevee was rendering a pure black cube in certain shader configurations in the default scene (#122837). This only affects X Elite devices (8cx Gen3 is unaffected).

Anthony Roberts commented

2024-09-04 16:15:56 +02:00

@blender-bot package windows-arm64

Blender Bot commented

2024-09-04 16:16:46 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR127148) when ready.

Anthony Roberts requested review from Jeroen Bakker 2024-09-04 16:21:15 +02:00

Anthony Roberts requested review from Clément Foucault 2024-09-04 16:21:15 +02:00

Anthony Roberts requested review from Ray molenkamp 2024-09-04 16:21:16 +02:00

Ray molenkamp reviewed 2024-09-04 16:27:52 +02:00

source/blender/gpu/opengl/gl_backend.cc

						
				@ -456,0 +466,4 @@

				      /* X Elite devices have GPU driver version 31, and currently no known release version of the

				       * GPU driver renders the cube correctly. This will be changed when a working driver version

				       * is released to commercial devices to only enable these flags on older drivers. */

				      if (ver0 == 31) {

Ray molenkamp commented

2024-09-04 16:27:52 +02:00

are there older versions we need to worry about?

Anthony Roberts commented

2024-09-04 16:36:01 +02:00

No, version 30.x.x.x, which is the current release on 8cx Gen3, doesn't have the issue.

Only public builds of 31.x.x.x (the current release on X Elite devices, the new generation) exhibit the issue. In the future, when we get a fixed version of the driver, I'll expand the check to only enable these flags below that sub-version

There is a similar check in that file (line 153) where I disable older drivers due to a bug, also, which by extension disables older devices.

No, version 30.x.x.x, which is the current release on 8cx Gen3, doesn't have the issue. Only public builds of 31.x.x.x (the current release on X Elite devices, the new generation) exhibit the issue. In the future, when we get a fixed version of the driver, I'll expand the check to only enable these flags below that sub-version There is a similar check in that file (line 153) where I disable older drivers due to a bug, also, which by extension disables older devices.

Ray molenkamp commented

2024-09-04 16:53:28 +02:00

Allright, fair enough, if driver 32 comes out and it doesn't fix the issue, people are back to black cubes for blender versions that may not get any more maintenance releases, if (ver0 >= 31) { be better here, You can always come in back later and add a && vers < N to whitelist the newer drivers and disable the workaround on those.

I'd rather see people on the workaround longer than needed, than potentially going back to black cubes.

Allright, fair enough, if driver 32 comes out and it _doesn't_ fix the issue, people are back to black cubes for blender versions that may not get any more maintenance releases, `if (ver0 >= 31) {` be better here, You can always come in back later and add a `&& vers < N` to whitelist the newer drivers and disable the workaround on those. I'd rather see people on the workaround longer than needed, than potentially going back to black cubes.

Anthony Roberts commented

2024-09-04 17:25:46 +02:00

Driver 32 would be with the next generation of chips that aren't due for a few years yet :) the new release for this gen would be a sub-version release, which I was intending on adding later - can swap it to a > though, no problem

Driver 32 would be with the next generation of chips that aren't due for a few years yet :) the new release for this gen would be a sub-version release, which I was intending on adding later - can swap it to a `>` though, no problem

Ray molenkamp approved these changes 2024-09-04 17:28:34 +02:00

Ray molenkamp left a comment

Nah, all good then!

Clément Foucault approved these changes 2024-09-04 17:52:33 +02:00

Anthony Roberts merged commit 5f34338296 into main

2024-09-04 18:20:14 +02:00

Anthony Roberts referenced this issue from a commit

2024-09-04 18:20:16 +02:00

Windows: Disable shader draw parameter support on certain Qualcomm GPUs

Anthony Roberts deleted branch x-elite-shader-draw-parameters

2024-09-04 18:20:18 +02:00

Philipp Oeser referenced this issue from a commit

2024-09-12 11:05:11 +02:00

Windows: Disable shader draw parameter support on certain Qualcomm GPUs

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Windows: Disable shader draw parameter support on certain Qualcomm GPUs #127148