Fix #127774: Flat Object matrix leads to incorrect culling #127807

Merged
Clément Foucault merged 2 commits from fclem/blender:fix-127774 into main 2024-09-19 14:10:16 +02:00

Object with degenerate transform matrix can lead to flat
bounds on GPU. This in turn lead to NaN intersection planes
inside IsectBox.

Compute (pseudo) size of matrix and bypass culling is any
axis is too small.

The other part of the patch makes sure that there is a
distinction between disabled culling and invalid
bounding boxes.

Object with degenerate transform matrix can lead to flat bounds on GPU. This in turn lead to NaN intersection planes inside `IsectBox`. Compute (pseudo) size of matrix and bypass culling is any axis is too small. The other part of the patch makes sure that there is a distinction between disabled culling and invalid bounding boxes.
Clément Foucault added the
Module
Viewport & EEVEE
label 2024-09-18 17:02:15 +02:00
Clément Foucault added 1 commit 2024-09-18 17:02:27 +02:00
Fix: #127774: Flat Object matrix leads to incorrect culling
Some checks failed
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
9d62cf5ba3
Object with degenerate transform matrix can lead to flat
bounds on GPU. This in turn lead to NaN intersection planes
inside IsectBox.

Compute (pseudo) size of matrix and bypass culling is any
axis is too small.

The other part of the patch makes sure that there is a
distinction between disabled culling and invalid
bounding boxes.
Author
Member

@blender-bot build

@blender-bot build
Clément Foucault added 1 commit 2024-09-18 17:57:33 +02:00
Fix stupid
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
5e3bad494c
Author
Member

@blender-bot build

@blender-bot build
Hans Goudey changed title from Fix: #127774: Flat Object matrix leads to incorrect culling to Fix #127774: Flat Object matrix leads to incorrect culling 2024-09-18 18:35:29 +02:00
Clément Foucault merged commit 02cf5f5f0f into main 2024-09-19 14:10:16 +02:00
Clément Foucault deleted branch fix-127774 2024-09-19 14:10:19 +02:00
Member

There are still several places in the code-base where an Isectbox is setup after checking for drw_bounds_are_valid.
Some of them just access the corners, so they should be fine (although we should use shape_box in those cases?) but others use the box for intersection testing.

There are still several places in the code-base where an `Isectbox` is setup after checking for `drw_bounds_are_valid`. Some of them just access the corners, so they should be fine (although we should use `shape_box` in those cases?) but others use the box for intersection testing.
Miguel Pozo referenced this issue from a commit 2024-09-25 19:59:00 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
glTF
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#127807
No description provided.