Build: Move WIX installer files to release/windows/installer_wix #128588

Merged
Sergey Sharybin merged 3 commits from Sergey/blender:win_installer_wix into blender-v4.3-release 2024-10-09 09:49:58 +02:00

This allows the files to be re-used between x64 and amd64 builds
for Windows.

This adds 500 kilobyte of files, but they almost never change, they
are required for releases anyway, and having them in the repo solves
all sort of synchronization problems.

This allows the files to be re-used between x64 and amd64 builds for Windows. This adds 500 kilobyte of files, but they almost never change, they are required for releases anyway, and having them in the repo solves all sort of synchronization problems.
Sergey Sharybin added 1 commit 2024-10-04 14:47:55 +02:00
This allows the files to be re-used between x64 and amd64 builds
for Windows.

This adds 500 kilobyte of files, but they almost never change, they
are required for releases anyway, and having them in the repo solves
all sort of synchronization problems.
Sergey Sharybin requested review from Ray molenkamp 2024-10-04 14:48:23 +02:00
Sergey Sharybin requested review from Anthony Roberts 2024-10-04 14:48:23 +02:00
Anthony Roberts approved these changes 2024-10-04 16:42:20 +02:00
Anthony Roberts left a comment
Member

LGTM, creates a functional installer on a WoA device

LGTM, creates a functional installer on a WoA device
Sergey Sharybin added 1 commit 2024-10-07 11:32:57 +02:00
Author
Owner

@LazyDodo Pablo updated the graphics, so from my perspective I don't think there are any stoppers for this PR.
I'll let him to take care of the release checklist etc (seems they want to go with per-release graphics, which I don't particularly mind).

@LazyDodo Pablo updated the graphics, so from my perspective I don't think there are any stoppers for this PR. I'll let him to take care of the release checklist etc (seems they want to go with per-release graphics, which I don't particularly mind).
Member

oh yeah, that's pure release management, there's no reason the platform module needs to be involved in any artistic choices

oh yeah, that's pure release management, there's no reason the platform module needs to be involved in any artistic choices
Ray molenkamp approved these changes 2024-10-07 14:51:42 +02:00
Ray molenkamp left a comment
Member

accepted, tentative on someone testing it and making sure the installer looks ok (think it's picky on the bitmap resolution as long as those didn't change, we should be fine) but it'll likely be a bit before i have a time slot to look at this.

So if you want to land sooner rather than later have someone test it, otherwise wait for me find some time for a test build .

accepted, tentative on someone testing it and making sure the installer looks ok (think it's picky on the bitmap resolution as long as those didn't change, we should be fine) but it'll likely be a bit before i have a time slot to look at this. So if you want to land sooner rather than later have someone test it, otherwise wait for me find some time for a test build .
Author
Owner

The resolution did not change. Good news: local compilation is all fine. Bad news: the second page and up are not really readable. I've talked to Pablo already. Hopefully it can be corrected very soon.

The resolution did not change. Good news: local compilation is all fine. Bad news: the second page and up are not really readable. I've talked to Pablo already. Hopefully it can be corrected very soon.
Sergey Sharybin added 1 commit 2024-10-08 18:31:45 +02:00
Author
Owner

@pablovazquez In case you wanted to see how it looks.

@pablovazquez In case you wanted to see how it looks.
Member

Thanks i was trying to imagine why page2+ would be unreadable, but it's just the banner by the looks of it makes sense now with the screenshots :)

Thanks i was trying to imagine why page2+ would be unreadable, but it's just the banner by the looks of it makes sense now with the screenshots :)
Sergey Sharybin changed target branch from main to blender-v4.3-release 2024-10-09 09:46:52 +02:00
Author
Owner

One thing I've noticed is the target branch was wrong. It actually is needed for 4.3, as it fixes WoA packaging. Think this is what we all were expecting from the PR anyway. So I'll land it now :)

One thing I've noticed is the target branch was wrong. It actually is needed for 4.3, as it fixes WoA packaging. Think this is what we all were expecting from the PR anyway. So I'll land it now :)
Sergey Sharybin merged commit 33320b50dd into blender-v4.3-release 2024-10-09 09:49:58 +02:00
Sergey Sharybin deleted branch win_installer_wix 2024-10-09 09:50:02 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#128588
No description provided.