WIP: Sculpt/Paint: Tag brushes for unsaved changes, indicate in the UI #128605

Closed
Julian Eisel wants to merge 6 commits from JulianEisel:temp-brush-asset-mark-changes into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Julian Eisel added the
Module
Sculpt, Paint & Texture
Interest
User Interface
labels 2024-10-04 17:59:06 +02:00
Julian Eisel added 1 commit 2024-10-04 17:59:18 +02:00
Julian Eisel added this to the Brush Assets & Asset Shelf project 2024-10-04 17:59:24 +02:00
Julian Eisel added 1 commit 2024-10-07 11:16:58 +02:00
Member

Interesting! I know this is WIP but leaving some thoughts.

Appending * to the display name helps and it's quite standard, but I wonder if it'd be better to have it prepended at the beginning of the name instead. As it may get trimmed when names don't fit the thumbnail:
trimmed names

Regarding the * Unsaved Changes label, I would avoid that since it moves the UI down. How about a Save icon or "Save Changes" operator in the "Brush Asset" panel header? Aligned to the right, where the presets icon usually is. Which is also the same place where other similar operations are (like Duplicate Asset).

Interesting! I know this is WIP but leaving some thoughts. Appending `*` to the display name helps and it's quite standard, but I wonder if it'd be better to have it prepended at the beginning of the name instead. As it may get trimmed when names don't fit the thumbnail: ![trimmed names](/attachments/b19ccd9b-e697-4b60-9e8a-49b0dfbe6738) Regarding the `* Unsaved Changes` label, I would avoid that since it moves the UI down. How about a Save icon or "Save Changes" operator in the "Brush Asset" panel header? Aligned to the right, where the presets icon usually is. Which is also the same place where other similar operations are (like Duplicate Asset).
Julian Eisel added 2 commits 2024-10-09 16:06:55 +02:00
Julian Eisel added 1 commit 2024-10-09 17:46:12 +02:00
Julian Eisel added 1 commit 2024-10-10 11:23:46 +02:00
Author
Member

There's now a button to save the brush asset in the panel header.

Screenshot from 2024-10-10 11-21-11.png

Some alternatives:

Screenshot from 2024-10-10 14-04-15.png Screenshot from 2024-10-10 14-06-12.png

The asset shelf doesn't indicate changed brushes yet, that's a little tricky code wise. We could still do it, but I'd first try to get the basics of this feature in.

The exact UI design we can still discuss & change, I'd propose moving forward with code review meanwhile.

There's now a button to save the brush asset in the panel header. ![Screenshot from 2024-10-10 11-21-11.png](/attachments/fe828918-b1eb-4e31-98d1-bfa5c3e2e63e) Some alternatives: | | | | --- | --- | | ![Screenshot from 2024-10-10 14-04-15.png](/attachments/ec8efd36-0125-4547-ad06-1784d79f1bb7) | ![Screenshot from 2024-10-10 14-06-12.png](/attachments/d3cccb68-d175-471c-bff1-6f9bf9beae07) | The asset shelf doesn't indicate changed brushes yet, that's a little tricky code wise. We could still do it, but I'd first try to get the basics of this feature in. The exact UI design we can still discuss & change, I'd propose moving forward with code review meanwhile.
Author
Member

Opened #128845 to propose this for the 4.3 release branch instead of main. I also created a quick design task to discuss the UI design further: #128846. Closing this.

Opened #128845 to propose this for the 4.3 release branch instead of `main`. I also created a quick design task to discuss the UI design further: #128846. Closing this.
Julian Eisel closed this pull request 2024-10-10 15:03:54 +02:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#128605
No description provided.