UI: Reorder EXR compression dropdown and add tooltips #128787
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#128787
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "aras_p/blender:exr_compression_items"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
OpenEXR has many compression codecs exposed, with some of them arguably
not very useful. Generally, for lossless compression you want ZIP or PIZ,
and for lossy compression you want DWAA/DWAB. Reorder the dropdown
entries so that these are at the top just below "No compression".
Previously the not-really-great choice of Pxr24 was the first.
Add tooltips to all the compression codecs too, trying to explain
what each of them does in once sentence.
Remove "(lossless)" labels and keep only "(lossy)" -- to me this is much easier
to visually parse, since both of them were very similar to each other before.
Dropdown before:
Dropdown now:
Generally fine, but the full-stop in the enum item description is something crazily unclear to me. We didn't use to have those as it was ensured to be added in the UI code. And there was an assert, afair. But now it all works correct regardless of full-stop being there or not?
@mont29 Do you have a more up-to-date guidelines? What's the proper thing to do for the translations?
P.S. Marking it as green from my side, as I don't really feel like it'll be required another iteration of review once the fullstop story is cleared out. But please clear it out with Bastien :)
We still do not expect any final fullstop in our UI messages AFAIK. Documentation about seems still missing though, CC @JulianEisel
To my knowledge, we typically use alphabetic ordering. If you still want ZIP and PIZ at the top, you could also add a separator line and sort just all the others alphabetically.
@JacquesLucke hmm but the previous order was very much not alphabetical already?
True, but that's not really an argument for anything.. Best wait for Julian or so to respond :)
The ending period shouldn't be needed. We're still discussing exact rules for this in the UI module, but in this case the tooltip drawing will add a period, so it's not necessary here. The warning about the period was removed, since there are valid cases where you'd want to have the period there.
Generally we try to make the UI smarter instead.
I can not see that we typically use alphabetical order. In some places we do maintain alphabetical order, in plenty others we do not. In many places it doesn't even make sense to order items alphabetically.
If we are to really block an improvement based on this then either make the current state of code follow the rule you're trying to enforce, or have a design/todo explaining what actually is expected to happen.
I'm not aware that we'd use alphabetical ordering for such cases. That would limit us quite a bit, I can see plenty of reasons why other ordering would be preferred.