Fix #128831: GPv3: Crash when adding action track #128841

Merged
Falk David merged 1 commits from PratikPB2123/blender:128831-gpv3-nlacrash into main 2024-10-15 15:16:22 +02:00
Member

When grease pencil has no actions (ale->adt), id data block channel is
still added due to ANIMFILTER_ANIMDATA. This would lead to crash if
operator is accessing the AnimData (ale->adt). To fix this, make sure
adt exists before creating an animchannel.

Also resolves #121866.

When grease pencil has no actions (ale->adt), id data block channel is still added due to `ANIMFILTER_ANIMDATA`. This would lead to crash if operator is accessing the AnimData (ale->adt). To fix this, make sure adt exists before creating an animchannel. Also resolves #121866.
Pratik Borhade added 1 commit 2024-10-10 12:57:59 +02:00
When grease pencil has no actions (ale->adt), id data block channel is
still added due to `ANIMFILTER_ANIMDATA`. This would lead to crash if
operator is accessing the AnimData (ale->adt). To fix this, make sure
adt exists before creating a channel.
Pratik Borhade requested review from Falk David 2024-10-10 12:58:13 +02:00
Pratik Borhade requested review from Sybren A. Stüvel 2024-10-10 12:58:19 +02:00
Author
Member

BTW, PR also fixes #121866

BTW, PR also fixes #121866
Pratik Borhade added the
Module
Grease Pencil
label 2024-10-10 12:59:04 +02:00
Falk David approved these changes 2024-10-10 15:13:38 +02:00
Falk David left a comment
Member

Makes sense.

Makes sense.
Sybren A. Stüvel approved these changes 2024-10-15 15:07:37 +02:00
Sybren A. Stüvel left a comment
Member

That seems sensible to me.

That seems sensible to me.
Falk David merged commit 301b2ae183 into main 2024-10-15 15:16:22 +02:00
Pratik Borhade deleted branch 128831-gpv3-nlacrash 2024-10-16 13:38:15 +02:00
Author
Member

Thanks :)

Thanks :)

@PratikPB2123 Looks like this fix needs to also go to the 4.3 branch as well.

@PratikPB2123 Looks like this fix needs to also go to the 4.3 branch as well.
Author
Member

Thanks Jesse. Oops, it was merged in main directly :/
I should have changed the branch to 4.3 from header when submitting PR (It was originally created from 4.3 base branch)

I'll cherry pick the commit tomorrow :)

Thanks Jesse. Oops, it was merged in main directly :/ I should have changed the branch to 4.3 from header when submitting PR (It was originally created from 4.3 base branch) I'll cherry pick the commit tomorrow :)
Author
Member

I'll cherry pick the commit tomorrow :)

Done

> I'll cherry pick the commit tomorrow :) Done
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#128841
No description provided.