Anim: Remove 'Slotted Actions' experimental flag #128889
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
glTF
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#128889
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "dr.sybren/blender:anim/remove-slotted-actions-experimental-flag"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
TODO before landing:
This commit takes the 'Slotted Actions' out of the experimental phase.
As a result:
rna_struct.keyframe_insert
function) will try and share Actions between related data-blocks. See !126655 for more info about this.Auto-selection of the Action Slot upon assigning the Action works as follows. The first rule to find a slot wins.
This last step is what I was referring to with "Where these two goals did not converge, reliability and understandability for users was prioritised." For regular Action assignments (like via the Action selectors in the Properties editor) this rule doesn't apply, even though with legacy Actions the final state ("it is animated by this Action") differs from the final state with slotted Actions ("it has no slot so is not animated"). This is done to support the following workflow:
If rule 4. above would apply in this case, the 2nd step would automatically select the Cube slot for Suzanne as well, which would immediately overwrite Suzanne's properties with the Cube animation.
Technically, this commit:
WITH_ANIM_BAKLAVA
build flag,use_animation_baklava
experimental flag in preferences,Note that 'slotted Actions' and 'layered Actions' are the exact same thing, just focusing on different aspects (slot & layers) of the new data model.
The "Baklava phase 1" assumptions are still asserted. This means that:
The code to handle legacy Actions is NOT removed in this commit. It will be removed later. For now it's likely better to keep it around as reference to the old behaviour in order to aid in some inevitable bugfixing.
Ref: #120406
This PR also contains #128892, which should definitely land first. After that I'll rebase this PR to clean it up.
941f05070e
to8493c505b3
8493c505b3
to8b20a4b0cb
@blender-bot build
8b20a4b0cb
tobd59525805
@blender-bot build
bd59525805
to6b316a115b
6b316a115b
toae1e21d78e
@blender-bot build
@blender-bot build
WIP: Anim: Remove 'Slotted Actions' experimental flagto Anim: Remove 'Slotted Actions' experimental flag@blender-bot package
Package build started. Download here when ready.
e322fd50e5
tof05d3e2979
@blender-bot build
Based on what you said in person earlier and looking at the two PRs, I assume this is no longer true and has already been rebased?
Didn't catch anything that looks wrong, so I think as soon as #129002 lands we can land this.
(Although for some reason my attempt to kick off a build bot for that failed. I'll try again.)
@blender-bot build
@blender-bot build
The buildbot build was succesful. It just failed on the linter on code that isn't touched by this PR.
The tests we performed before accepting & landing this PR:
Slotted Action Testing
A list of issues discovered while testing slotted actions with addons, production files, etc. after taking them out of experimental:
#128889: WIP: Anim: Remove 'Slotted Actions' experimental flag
General Poking
Addon Testing
✅ Camera Shakify:
The code that assigns the action to the action constraints no longer works, breaking the addon. This is a twofold issue:Just in general, assigning an action with one slot with an unspecified id_type doesn't auto-assign the slot like it should.Camera Shakify has a workaround for a (now fixed) bug in Blender, and that work-around sets the id_type of the slot before attempting to assign to the action constraint.Action to Scene Range
BLI_assert
) when trying to switch actions. Come back to this later after that's fixed.bpy.types.SpaceDopeSheetEditor
property doesn't change any more. We may want to see if we can get that to work again. (add-on source)✅ Nuke Animation Format (.chan)
✅ Bake Shape Keys
✅ Convert Rotation Mode
✅ Export Camera Animation
Unreal PSK/PSA (.psk/.psa)
?? VRM format
import
of gltf, so probably not us.✅ Real Time Paths
✅ AnimAll
✅ Cake_Particles
✅ CloudRig
✅ Rigify
✅ Gold Production File Testing
Grease Pencil Demos
shots
directory for playback, and they all worked identically to Blender 4.3 beta.Other test files