Cleanup: Various non-functional changes for paint_stroke.cc #129576

Merged
Sean Kim merged 3 commits from Sean-Kim/blender:cleanup-paint-stroke-cc into main 2024-10-31 21:12:16 +01:00
Member

This commit applies the following changes:

  • Use c++ math types instead of float / int arrays where possible
  • Use c++ math library where c++ math types are used
  • Use const where possible
  • Reduces scope of variables where possible
  • Clarifies some variable naming (e.g. d prefix to _delta suffix)

The main areas left untouched are anything that is part of a public
function signature to avoid making changes in many different files at
once.

This commit applies the following changes: * Use c++ math types instead of float / int arrays where possible * Use c++ math library where c++ math types are used * Use const where possible * Reduces scope of variables where possible * Clarifies some variable naming (e.g. d prefix to _delta suffix) The main areas left untouched are anything that is part of a public function signature to avoid making changes in many different files at once.
Sean Kim added 1 commit 2024-10-30 06:31:50 +01:00
Cleanup: Various non-fucntional changes for paint_stroke.cc
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
1a968edc88
This commit applies the following changes:
* Use c++ math types instead of float / int arrays where possible
* Use c++ math library where c++ math types are used
* Use const where possible
* Reduces scope of variables where possible
* Clarifies some variable naming (e.g. d prefix to _delta suffix)

The main areas left untouched are anything that is part of a public
function signature to avoid making changes in many different files at
once.
Sean Kim added this to the Sculpt, Paint & Texture project 2024-10-30 06:31:54 +01:00
Author
Member

@blender-bot build

@blender-bot build
Sean Kim force-pushed cleanup-paint-stroke-cc from 1a968edc88 to cb418924d4 2024-10-30 21:29:14 +01:00 Compare
Sean Kim changed title from Cleanup: Various non-fucntional changes for paint_stroke.cc to Cleanup: Various non-functional changes for paint_stroke.cc 2024-10-30 22:44:10 +01:00
Sean Kim added 1 commit 2024-10-31 01:50:47 +01:00
Sean Kim reviewed 2024-10-31 02:01:15 +01:00
@ -424,4 +426,1 @@
else {
/* here we are using the initial mouse coordinate because we do not want the rake
* result to depend on jittering */
if (!stroke->brush_init) {
Author
Member

Note for posterity:

This is dead code, stroke->brush_init will be set to true on line 319, and ups.last_rake is initialized there as well

Note for posterity: This is dead code, `stroke->brush_init` will be set to true on line 319, and `ups.last_rake` is initialized there as well
Sean Kim added 1 commit 2024-10-31 02:20:21 +01:00
Fix line constraint
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
90fcfc1863
Author
Member

@blender-bot build

@blender-bot build
Sean Kim merged commit dd7064b2e1 into main 2024-10-31 21:12:16 +01:00
Sean Kim deleted branch cleanup-paint-stroke-cc 2024-10-31 21:12:19 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#129576
No description provided.